CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-24 00:54:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Randomize form field ids to thwart browser memory and help with embedding iD (close #6444)

Browse Source
This commit is contained in:
Quincy Morgan
2020-03-21 13:16:40 -07:00
parent dd40f3b52d
commit 4872b06a28
11 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/ui/commit.js
+5 -3
View File
@@ -11,7 +11,7 @@ import { uiChangesetEditor } from './changeset_editor';
import { uiSectionChanges } from './sections/changes';
import { uiCommitWarnings } from './commit_warnings';
import { uiSectionRawTagEditor } from './sections/raw_tag_editor';
import { utilArrayGroupBy, utilRebind } from '../util';
import { utilArrayGroupBy, utilRebind, utilUniqueDomId } from '../util';
import { utilDetect } from '../util/detect';
@@ -311,14 +311,16 @@ export function uiCommit(context) {
.append('div')
.attr('class', 'request-review');
var id = utilUniqueDomId('commit-input-request-review');
var labelEnter = requestReviewEnter
.append('label')
.attr('for', 'commit-input-request-review');
.attr('for', id);
labelEnter
.append('input')
.attr('type', 'checkbox')
.attr('id', 'commit-input-request-review');
.attr('id', id);
labelEnter
.append('span')