CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-06-05 14:38:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix test failures in localized and suspicious_names

Browse Source
This commit is contained in:
Bryan Housel
2020-02-03 12:37:43 -05:00
parent b2b2689fb2
commit 4aa4686e7f
4 changed files with 216 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/spec/ui/fields/localized.js
+101 -74
View File
@@ -22,121 +22,148 @@ describe('iD.uiFieldLocalized', function() {
});
it('adds a blank set of fields when the + button is clicked', function() {
it('adds a blank set of fields when the + button is clicked', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
expect(selection.selectAll('.localized-lang').nodes().length).to.equal(1);
expect(selection.selectAll('.localized-value').nodes().length).to.equal(1);
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
expect(selection.selectAll('.localized-lang').nodes().length).to.equal(1);
expect(selection.selectAll('.localized-value').nodes().length).to.equal(1);
done();
}, 20);
});
it('doesn\'t create a tag when the value is empty', function() {
it('doesn\'t create a tag when the value is empty', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
localized.on('change', function(tags) {
expect(tags).to.eql({});
});
localized.on('change', function(tags) {
expect(tags).to.eql({});
});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'Deutsch');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
happen.once(selection.selectAll('.localized-lang').node(), {type: 'blur'});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'Deutsch');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
happen.once(selection.selectAll('.localized-lang').node(), {type: 'blur'});
done();
}, 20);
});
it('doesn\'t create a tag when the name is empty', function() {
it('doesn\'t create a tag when the name is empty', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
localized.on('change', function(tags) {
expect(tags).to.eql({});
});
localized.on('change', function(tags) {
expect(tags).to.eql({});
});
iD.utilGetSetValue(selection.selectAll('.localized-value'), 'Value');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
happen.once(selection.selectAll('.localized-value').node(), {type: 'blur'});
iD.utilGetSetValue(selection.selectAll('.localized-value'), 'Value');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
happen.once(selection.selectAll('.localized-value').node(), {type: 'blur'});
done();
}, 20);
});
it('creates a tag after setting language then value', function() {
it('creates a tag after setting language then value', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'Deutsch');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'Deutsch');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': 'Value'});
});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': 'Value'});
});
iD.utilGetSetValue(selection.selectAll('.localized-value'), 'Value');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-value'), 'Value');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
done();
}, 20);
});
it('creates a tag after setting value then language', function() {
it('creates a tag after setting value then language', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
happen.click(selection.selectAll('.localized-add').node());
iD.utilGetSetValue(selection.selectAll('.localized-value'), 'Value');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-value'), 'Value');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': 'Value'});
});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': 'Value'});
});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'Deutsch');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'Deutsch');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
done();
}, 20);
});
it('changes an existing language', function() {
it('changes an existing language', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
localized.tags({'name:de': 'Value'});
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
localized.tags({'name:de': 'Value'});
localized.on('change', function(tags) {
expect(tags).to.eql({
'name:de': undefined,
'name:en': 'Value'});
});
localized.on('change', function(tags) {
expect(tags).to.eql({
'name:de': undefined,
'name:en': 'Value'});
});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'English');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), 'English');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
done();
}, 20);
});
it('ignores similar keys like `old_name`', function() {
it('ignores similar keys like `old_name`', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
localized.tags({'old_name:de': 'Value'});
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
localized.tags({'old_name:de': 'Value'});
expect(selection.selectAll('.localized-lang').empty()).to.be.ok;
expect(selection.selectAll('.localized-value').empty()).to.be.ok;
expect(selection.selectAll('.localized-lang').empty()).to.be.ok;
expect(selection.selectAll('.localized-value').empty()).to.be.ok;
done();
}, 20);
});
it('removes the tag when the language is emptied', function() {
it('removes the tag when the language is emptied', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
localized.tags({'name:de': 'Value'});
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
localized.tags({'name:de': 'Value'});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': undefined});
});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': undefined});
});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), '');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-lang'), '');
happen.once(selection.selectAll('.localized-lang').node(), {type: 'change'});
done();
}, 20);
});
it('removes the tag when the value is emptied', function() {
it('removes the tag when the value is emptied', function(done) {
var localized = iD.uiFieldLocalized(field, context);
selection.call(localized);
localized.tags({'name:de': 'Value'});
window.setTimeout(function() { // async, so data will be available
selection.call(localized);
localized.tags({'name:de': 'Value'});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': undefined});
});
localized.on('change', function(tags) {
expect(tags).to.eql({'name:de': undefined});
});
iD.utilGetSetValue(selection.selectAll('.localized-value'), '');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
iD.utilGetSetValue(selection.selectAll('.localized-value'), '');
happen.once(selection.selectAll('.localized-value').node(), {type: 'change'});
done();
}, 20);
});
});