From 4e6ade08b1fae1194b751dfa9533745939d6abfa Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Tue, 12 Feb 2019 00:22:24 -0500 Subject: [PATCH] Comment out cache in getIssuesForEntityWithID It seems like entity editor draws before the validator runs so the rendered list is often one history change behind. --- modules/core/validator.js | 4 ++-- modules/ui/entity_issues.js | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/modules/core/validator.js b/modules/core/validator.js index 47c92120e..c38dd0170 100644 --- a/modules/core/validator.js +++ b/modules/core/validator.js @@ -65,10 +65,10 @@ export function coreValidator(context) { self.getIssuesForEntityWithID = function(entityID) { if (!context.hasEntity(entityID)) return []; - if (!_issuesByEntityID[entityID]) { + // if (!_issuesByEntityID[entityID]) { var entity = context.entity(entityID); _issuesByEntityID[entityID] = validateEntity(entity); - } + // } return _issuesByEntityID[entityID]; }; diff --git a/modules/ui/entity_issues.js b/modules/ui/entity_issues.js index d425d97c6..023f72614 100644 --- a/modules/ui/entity_issues.js +++ b/modules/ui/entity_issues.js @@ -14,11 +14,11 @@ export function uiEntityIssues(context) { var _entityID; - context.validator().on('reload.entity_issues', function() { - _selection.selectAll('.entity-issues') - .call(render); - update(); - }); + // context.validator().on('reload.entity_issues', function() { + // _selection.selectAll('.entity-issues') + // .call(render); + // update(); + // }); function clamp(num, min, max) {