From 4eabf2da07b0a4002cfc95f0599fb19261780107 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Tue, 26 Feb 2019 12:09:16 -0500
Subject: [PATCH] Add unit tests for old multipolygon validation

---
 test/index.html                           | 13 ++--
 test/spec/validations/old_multipolygon.js | 75 +++++++++++++++++++++++
 2 files changed, 82 insertions(+), 6 deletions(-)
 create mode 100644 test/spec/validations/old_multipolygon.js

diff --git a/test/index.html b/test/index.html
index 62bca52a5..98d454dc3 100644
--- a/test/index.html
+++ b/test/index.html
@@ -146,13 +146,14 @@
     <script src='spec/util/util.js'></script>
 
     <script src='spec/validations/validator.js'></script>
-    <script src='spec/validations/deprecated_tag.js'></script>
-    <script src='spec/validations/missing_tag.js'></script>
-    <script src='spec/validations/missing_role.js'></script>
-    <script src='spec/validations/disconnected_way.js'></script>
-    <script src='spec/validations/tag_suggests_area.js'></script>
-    <script src='spec/validations/crossing_ways.js'></script>
     <script src='spec/validations/almost_junction.js'></script>
+    <script src='spec/validations/crossing_ways.js'></script>
+    <script src='spec/validations/deprecated_tag.js'></script>
+    <script src='spec/validations/disconnected_way.js'></script>
+    <script src='spec/validations/missing_role.js'></script>
+    <script src='spec/validations/missing_tag.js'></script>
+    <script src='spec/validations/old_multipolygon.js'></script>
+    <script src='spec/validations/tag_suggests_area.js'></script>
 
     <script src='spec/operations/detach_node.js'></script>
     <script>
diff --git a/test/spec/validations/old_multipolygon.js b/test/spec/validations/old_multipolygon.js
new file mode 100644
index 000000000..e7069c4e5
--- /dev/null
+++ b/test/spec/validations/old_multipolygon.js
@@ -0,0 +1,75 @@
+describe('iD.validations.old_multipolygon', function () {
+    var context;
+
+    beforeEach(function() {
+        context = iD.coreContext();
+    });
+
+    function createWay(tags) {
+        var n1 = iD.osmNode({id: 'n-1', loc: [4,4]});
+        var n2 = iD.osmNode({id: 'n-2', loc: [4,5]});
+        var w = iD.osmWay({id: 'w-1', nodes: ['n-1', 'n-2'], tags: tags});
+
+        context.perform(
+            iD.actionAddEntity(n1),
+            iD.actionAddEntity(n2),
+            iD.actionAddEntity(w)
+        );
+    }
+
+    function createRelation(wayTags, relationTags) {
+        var n1 = iD.osmNode({id: 'n-1', loc: [4,4]});
+        var n2 = iD.osmNode({id: 'n-2', loc: [4,5]});
+        var n3 = iD.osmNode({id: 'n-3', loc: [5,5]});
+        var w = iD.osmWay({id: 'w-1', nodes: ['n-1', 'n-2', 'n-3', 'n-1'], tags: wayTags});
+        var r = iD.osmRelation({id: 'r-1', members: [{id: 'w-1'}], tags: relationTags});
+
+        context.perform(
+            iD.actionAddEntity(n1),
+            iD.actionAddEntity(n2),
+            iD.actionAddEntity(n3),
+            iD.actionAddEntity(w),
+            iD.actionAddEntity(r)
+        );
+    }
+
+    function validate() {
+        var validator = iD.validationOldMultipolygon();
+        var changes = context.history().changes();
+        var entities = changes.modified.concat(changes.created);
+        var issues = [];
+        entities.forEach(function(entity) {
+            issues = issues.concat(validator(entity, context));
+        });
+        return issues;
+    }
+
+    it('has no errors on init', function() {
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores way with no relations', function() {
+        createWay({});
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores multipolygon tagged on the relation', function() {
+        createRelation({}, { type: 'multipolygon', building: 'yes' });
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('flags multipolygon tagged on the outer way', function() {
+        createRelation({ building: 'yes' }, { type: 'multipolygon' });
+        var issues = validate();
+        expect(issues).to.not.have.lengthOf(0);
+        var issue = issues[0];
+        expect(issue.type).to.eql('old_multipolygon');
+        expect(issue.entities).to.have.lengthOf(2);
+        expect(issue.entities[0].id).to.eql('w-1');
+        expect(issue.entities[1].id).to.eql('r-1');
+    });
+
+});