From 2fd5deb2e9fcf62fe629efbf3aa81d89a34dd5aa Mon Sep 17 00:00:00 2001 From: Ansis Brammanis Date: Thu, 21 Feb 2013 00:27:38 -0500 Subject: [PATCH 1/2] Fix additional tag collapsed icon --- js/id/ui/taglist.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/id/ui/taglist.js b/js/id/ui/taglist.js index 2a0d4af62..408571a20 100644 --- a/js/id/ui/taglist.js +++ b/js/id/ui/taglist.js @@ -13,6 +13,7 @@ iD.ui.Taglist = function() { .attr('class','hide-toggle') .text('Additional tags') .on('click', function() { + collapsebutton.classed('expanded', wrap.classed('hide')); wrap.call(iD.ui.Toggle(wrap.classed('hide'))); selection.node().parentNode.scrollTop += 200; }); @@ -38,7 +39,7 @@ iD.ui.Taglist = function() { .attr('class', 'label') .text(t('inspector.new_tag')); - collapsebutton.classed('expanded', collapsed); + collapsebutton.classed('expanded', !collapsed); wrap.classed('hide', collapsed); } From 450130904295d20276caf3219db2c12230c94af1 Mon Sep 17 00:00:00 2001 From: Ansis Brammanis Date: Thu, 21 Feb 2013 00:28:10 -0500 Subject: [PATCH 2/2] Fix setting key on address fields --- js/id/ui/address.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/id/ui/address.js b/js/id/ui/address.js index fb96169f1..75a712768 100644 --- a/js/id/ui/address.js +++ b/js/id/ui/address.js @@ -37,22 +37,22 @@ iD.ui.preset.address = function() { .property('type', 'text') .attr('placeholder', 'Housename') .attr('class', 'addr-housename') - .data({ 'key': 'addr:housename' }); + .datum({ 'key': 'addr:housename' }); selection.append('input') .property('type', 'text') .attr('placeholder', '123') .attr('class', 'addr-number') - .data({ 'key': 'addr:housenumber' }); + .datum({ 'key': 'addr:housenumber' }); var streetwrap = selection.append('span') - .attr('class', 'input-wrap-position'); + .attr('class', 'input-wrap-position') + .datum({ 'key': 'addr:streetname' }); streetwrap.append('input') .property('type', 'text') .attr('placeholder', 'Oak Street') - .attr('class', 'addr-streetname') - .data({ 'key': 'addr:streetname' }); + .attr('class', 'addr-streetname'); streetwrap.call(d3.combobox().data(getStreets())); }