From 5160754dcc62c9d8cedcb2d1ca1feb2d21ffe774 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Tue, 7 May 2019 13:07:31 -0400 Subject: [PATCH] Display issues for disabled rules in the commit UI Allow errors for disabled rules to block upload Include warnings for disabled rules in the changeset tags (re: #6325) --- modules/ui/commit.js | 2 +- modules/ui/commit_warnings.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/ui/commit.js b/modules/ui/commit.js index a777a7994..c7817283a 100644 --- a/modules/ui/commit.js +++ b/modules/ui/commit.js @@ -123,7 +123,7 @@ export function uiCommit(context) { // add counts of warnings generated by the user's edits var warnings = context.validator() - .getIssuesBySeverity({ what: 'edited', where: 'all', includeIgnored: true }).warning; + .getIssuesBySeverity({ what: 'edited', where: 'all', includeIgnored: true, includeDisabledRules: true }).warning; var warningsByType = utilArrayGroupBy(warnings, 'type'); for (var warningType in warningsByType) { diff --git a/modules/ui/commit_warnings.js b/modules/ui/commit_warnings.js index b5b59cafa..329e5bcb4 100644 --- a/modules/ui/commit_warnings.js +++ b/modules/ui/commit_warnings.js @@ -9,7 +9,7 @@ export function uiCommitWarnings(context) { function commitWarnings(selection) { var issuesBySeverity = context.validator() - .getIssuesBySeverity({ what: 'edited', where: 'all' }); + .getIssuesBySeverity({ what: 'edited', where: 'all', includeDisabledRules: true }); for (var severity in issuesBySeverity) { var issues = issuesBySeverity[severity];