CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-21 07:46:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update and standardise QA implementations

Browse Source 
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
This commit is contained in:
SilentSpike
2020-02-05 14:23:34 +00:00
parent 9faf8c0fe5
commit 51efd5b714
33 changed files with 2823 additions and 3079 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/build_data.js
+7 -8
View File
@@ -90,7 +90,7 @@ function buildData() {
'dist/data/*',
'svg/fontawesome/*.svg',
]);
readQAErrorIcons(faIcons, tnpIcons);
readQAIssueIcons(faIcons, tnpIcons);
let categories = generateCategories(tstrings, faIcons, tnpIcons);
let fields = generateFields(tstrings, faIcons, tnpIcons, searchableFieldIDs);
let presets = generatePresets(tstrings, faIcons, tnpIcons, searchableFieldIDs);
@@ -128,7 +128,7 @@ function buildData() {
minifyJSON('data/languages.json', 'dist/data/languages.min.json'),
minifyJSON('data/locales.json', 'dist/data/locales.min.json'),
minifyJSON('data/phone_formats.json', 'dist/data/phone_formats.min.json'),
minifyJSON('data/qa_errors.json', 'dist/data/qa_errors.min.json'),
minifyJSON('data/qa_data.json', 'dist/data/qa_data.min.json'),
minifyJSON('data/shortcuts.json', 'dist/data/shortcuts.min.json'),
minifyJSON('data/taginfo.json', 'dist/data/taginfo.min.json'),
minifyJSON('data/territory_languages.json', 'dist/data/territory_languages.min.json')
@@ -173,13 +173,12 @@ function validate(file, instance, schema) {
}
function readQAErrorIcons(faIcons, tnpIcons) {
const qa = read('data/qa_errors.json');
function readQAIssueIcons(faIcons, tnpIcons) {
const qa = read('data/qa_data.json');
for (const service in qa.services) {
for (const error in qa.services[service].errorIcons) {
const icon = qa.services[service]
.errorIcons[error];
for (const service in qa) {
for (const item in qa[service].icons) {
const icon = qa[service].icons[item];
// fontawesome icon, remember for later
if (/^fa[srb]-/.test(icon)) {