CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-20 15:34:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

Recategorize tags_suggests_area validation rule into mismatched_geometry rule

Browse Source 
Warn about points tagged as vertices and vertices tagged as points (close #6319)
This commit is contained in:
Quincy Morgan
2019-09-26 10:56:30 +02:00
parent d43cf85fe6
commit 525916da74
8 changed files with 239 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/index.html
+1 -1
View File
@@ -157,12 +157,12 @@
<script src='spec/validations/disconnected_way.js'></script>
<script src='spec/validations/generic_name.js'></script>
<script src='spec/validations/incompatible_source.js'></script>
<script src='spec/validations/mismatched_geometry.js'></script>
<script src='spec/validations/missing_role.js'></script>
<script src='spec/validations/missing_tag.js'></script>
<script src='spec/validations/old_multipolygon.js'></script>
<script src='spec/validations/outdated_tags.js'></script>
<script src='spec/validations/private_data.js'></script>
<script src='spec/validations/tag_suggests_area.js'></script>
<script>
window.mocha.run();
test/spec/validations/tag_suggests_area.js → test/spec/validations/mismatched_geometry.js
+6 -4
View File
@@ -1,4 +1,4 @@
describe('iD.validations.tag_suggests_area', function () {
describe('iD.validations.mismatched_geometry', function () {
var context;
beforeEach(function() {
@@ -41,7 +41,7 @@ describe('iD.validations.tag_suggests_area', function () {
}
function validate() {
var validator = iD.validationTagSuggestsArea(context);
var validator = iD.validationMismatchedGeometry(context);
var changes = context.history().changes();
var entities = changes.modified.concat(changes.created);
var issues = [];
@@ -86,7 +86,8 @@ describe('iD.validations.tag_suggests_area', function () {
var issues = validate();
expect(issues).to.have.lengthOf(1);
var issue = issues[0];
expect(issue.type).to.eql('tag_suggests_area');
expect(issue.type).to.eql('mismatched_geometry');
expect(issue.subtype).to.eql('area_as_line');
expect(issue.severity).to.eql('warning');
expect(issue.entityIds).to.have.lengthOf(1);
expect(issue.entityIds[0]).to.eql('w-1');
@@ -97,7 +98,8 @@ describe('iD.validations.tag_suggests_area', function () {
var issues = validate();
expect(issues).to.have.lengthOf(1);
var issue = issues[0];
expect(issue.type).to.eql('tag_suggests_area');
expect(issue.type).to.eql('mismatched_geometry');
expect(issue.subtype).to.eql('area_as_line');
expect(issue.severity).to.eql('warning');
expect(issue.entityIds).to.have.lengthOf(1);
expect(issue.entityIds[0]).to.eql('w-1');