From 54886339f6bcdc3cf5f8fdf8dc5f650de7bc1706 Mon Sep 17 00:00:00 2001 From: Martin Raifer Date: Mon, 29 Nov 2021 19:21:29 +0100 Subject: [PATCH] fix code lint issue, move additional logic into display methods --- modules/ui/fields/restrictions.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/modules/ui/fields/restrictions.js b/modules/ui/fields/restrictions.js index 6af0c854d..1b2033bd8 100644 --- a/modules/ui/fields/restrictions.js +++ b/modules/ui/fields/restrictions.js @@ -151,7 +151,6 @@ export function uiFieldRestrictions(field, context) { }); selection.selectAll('.restriction-distance-text') - .html('') .call(displayMaxDistance(_maxDistance)); @@ -194,7 +193,6 @@ export function uiFieldRestrictions(field, context) { }); selection.selectAll('.restriction-via-way-text') - .html('') .call(displayMaxVia(_maxViaWay)); } @@ -604,17 +602,20 @@ export function uiFieldRestrictions(field, context) { opts = { distance: t('units.meters', { quantity: maxDist }) }; } - return selection.call(t.htmlDom('restriction.controls.distance_up_to', opts)); - } + return selection + .html('') + .call(t.htmlDom('restriction.controls.distance_up_to', opts)); + }; } function displayMaxVia(maxVia) { return selection => { + selection = selection.html(''); return maxVia === 0 ? selection.call(t.htmlDom('restriction.controls.via_node_only')) : maxVia === 1 ? selection.call(t.htmlDom('restriction.controls.via_up_to_one')) : selection.call(t.htmlDom('restriction.controls.via_up_to_two')); - } + }; }