From 59b0252b0e3bd2ea320a78514a849b0ffc48d007 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Wed, 19 Dec 2018 13:22:48 -0500 Subject: [PATCH] Fixed several linting errors --- modules/ui/commit_warnings.js | 2 +- modules/ui/issues.js | 13 +++---------- modules/validations/disconnected_highway.js | 7 +++++-- modules/validations/validation_issue.js | 2 +- 4 files changed, 10 insertions(+), 14 deletions(-) diff --git a/modules/ui/commit_warnings.js b/modules/ui/commit_warnings.js index 93c11cc39..c9f508530 100644 --- a/modules/ui/commit_warnings.js +++ b/modules/ui/commit_warnings.js @@ -105,7 +105,7 @@ export function uiCommitWarnings(context) { context.map().zoomTo(d.entities[0]); context.enter(modeSelect( context, - _map(d.entities, function(e) { return e.id; }), + _map(d.entities, function(e) { return e.id; }) )); } } diff --git a/modules/ui/issues.js b/modules/ui/issues.js index 408d359a4..204a8dfdd 100644 --- a/modules/ui/issues.js +++ b/modules/ui/issues.js @@ -7,20 +7,15 @@ import { import { svgIcon } from '../svg'; import { t, textDirection } from '../util/locale'; import { tooltip } from '../util/tooltip'; -import { geoExtent } from '../geo'; -import { modeBrowse, - modeSelect -} from '../modes'; +import { modeSelect } from '../modes'; import { uiBackground } from './background'; import { uiDisclosure } from './disclosure'; import { uiHelp } from './help'; import { uiMapData } from './map_data'; -import { uiSettingsCustomData } from './settings/custom_data'; import { uiTooltipHtml } from './tooltipHtml'; export function uiIssues(context) { var key = t('issues.key'); - var _issuesOptionsContainer = d3_select(null); var _featureApplicabilityList = d3_select(null); var _issuesList = d3_select(null); var _shown = false; @@ -29,7 +24,7 @@ export function uiIssues(context) { var container = selection.selectAll('.issues-options-container') .data([0]); - _issuesOptionsContainer = container.enter() + container = container.enter() .append('div') .attr('class', 'issues-options-container') .merge(container); @@ -37,7 +32,7 @@ export function uiIssues(context) { _featureApplicabilityList = container.selectAll('.feature-applicability-list') .data([0]); - _featureApplicabilityList = container.enter() + _featureApplicabilityList = _featureApplicabilityList.enter() .append('ul') .attr('class', 'layer-list feature-applicability-list') .merge(_featureApplicabilityList); @@ -99,8 +94,6 @@ export function uiIssues(context) { function drawIssuesList(selection) { - var name = 'issues_list'; - var issues = context.issueManager().getIssues(); /*validations = _reduce(issues, function(validations, val) { diff --git a/modules/validations/disconnected_highway.js b/modules/validations/disconnected_highway.js index 86a2dd0c0..6a3cd088f 100644 --- a/modules/validations/disconnected_highway.js +++ b/modules/validations/disconnected_highway.js @@ -1,5 +1,8 @@ import { t } from '../util/locale'; -import { utilDisplayName } from '../util'; +import { + utilDisplayName, + utilDisplayType +} from '../util'; import { ValidationIssueType, ValidationIssueSeverity, @@ -40,7 +43,7 @@ export function validationDisconnectedHighway(context) { if (preset && preset.name()) { entityLabel = preset.name(); } else { - entityLabel = utilDisplayType(entity.id) + entityLabel = utilDisplayType(entity.id); } } diff --git a/modules/validations/validation_issue.js b/modules/validations/validation_issue.js index c671a0bd3..2b159c6a9 100644 --- a/modules/validations/validation_issue.js +++ b/modules/validations/validation_issue.js @@ -27,7 +27,7 @@ export function validationIssue(attrs) { throw new Error('Invalid attrs.type: ' + attrs.type); } if (!attrs.severity || !ValidationIssueSeverity.hasOwnProperty(attrs.severity)) { - throw new Error('Invalid attrs.severity: ' + attr.severity); + throw new Error('Invalid attrs.severity: ' + attrs.severity); } if (!attrs.message) throw new Error('attrs.message is empty');