From 59b1d4d28d66e3774f06382e44d45cafd373511f Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Thu, 21 Mar 2019 11:37:23 -0400
Subject: [PATCH] Add tests for unknown_road validation

---
 test/index.html                       |  1 +
 test/spec/validations/unknown_road.js | 58 +++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 test/spec/validations/unknown_road.js

diff --git a/test/index.html b/test/index.html
index 783216903..5bd094eca 100644
--- a/test/index.html
+++ b/test/index.html
@@ -154,6 +154,7 @@
     <script src='spec/validations/old_multipolygon.js'></script>
     <script src='spec/validations/outdated_tags.js'></script>
     <script src='spec/validations/tag_suggests_area.js'></script>
+    <script src='spec/validations/unknown_road.js'></script>
 
     <script src='spec/operations/detach_node.js'></script>
     <script>
diff --git a/test/spec/validations/unknown_road.js b/test/spec/validations/unknown_road.js
new file mode 100644
index 000000000..48fcd510d
--- /dev/null
+++ b/test/spec/validations/unknown_road.js
@@ -0,0 +1,58 @@
+describe('iD.validations.unknown_road', function () {
+    var context;
+
+    beforeEach(function() {
+        context = iD.coreContext();
+    });
+
+    function createWay(tags) {
+        var n1 = iD.osmNode({id: 'n-1', loc: [4,4]});
+        var n2 = iD.osmNode({id: 'n-2', loc: [4,5]});
+        var w = iD.osmWay({id: 'w-1', nodes: ['n-1', 'n-2'], tags: tags});
+
+        context.perform(
+            iD.actionAddEntity(n1),
+            iD.actionAddEntity(n2),
+            iD.actionAddEntity(w)
+        );
+    }
+
+    function validate() {
+        var validator = iD.validationUnknownRoad();
+        var changes = context.history().changes();
+        var entities = changes.modified.concat(changes.created);
+        var issues = [];
+        entities.forEach(function(entity) {
+            issues = issues.concat(validator(entity, context));
+        });
+        return issues;
+    }
+
+    it('has no errors on init', function() {
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores way with no tags', function() {
+        createWay({});
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores highway with classification', function() {
+        createWay({ highway: 'primary' });
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('flags highway=road', function() {
+        createWay({ highway: 'road' });
+        var issues = validate();
+        expect(issues).to.have.lengthOf(1);
+        var issue = issues[0];
+        expect(issue.type).to.eql('unknown_road');
+        expect(issue.entities).to.have.lengthOf(1);
+        expect(issue.entities[0].id).to.eql('w-1');
+    });
+
+});