From 5a9749c51642f512cc7bea03f4c3f8694d3dff5a Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Mon, 27 Nov 2017 23:42:02 -0500 Subject: [PATCH] Fix bug that caused clicking a uiDisclosure to change the url (closes #4570) --- modules/ui/disclosure.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/modules/ui/disclosure.js b/modules/ui/disclosure.js index 45c6315a5..3b4c3a0a4 100644 --- a/modules/ui/disclosure.js +++ b/modules/ui/disclosure.js @@ -1,4 +1,5 @@ import { dispatch as d3_dispatch } from 'd3-dispatch'; +import { event as d3_event } from 'd3-selection'; import { utilRebind } from '../util/rebind'; import { uiToggle } from './toggle'; @@ -43,12 +44,15 @@ export function uiDisclosure(context, key, expandedDefault) { function toggle() { + d3_event.preventDefault(); + _expanded = !_expanded; if (_updatePreference) { context.storage('disclosure.' + key + '.expanded', _expanded); } hideToggle.classed('expanded', _expanded); wrap.call(uiToggle(_expanded)); + dispatch.call('toggled', this, _expanded); } };