From 5b8db55b47c0ba97e73972468a1d908a82d1dd60 Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Wed, 22 May 2019 23:47:53 -0400 Subject: [PATCH] Need issue `id` to actually change for d3 to replace it (re: #6407) What's happening here is that the validator is updating the issues, but the entity_issues component leaves the original issue in the list because the `id` has not changed. Need to review all the validators to see if others have this problem too. --- modules/validations/outdated_tags.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/validations/outdated_tags.js b/modules/validations/outdated_tags.js index 24ba13390..54c05d8eb 100644 --- a/modules/validations/outdated_tags.js +++ b/modules/validations/outdated_tags.js @@ -4,6 +4,7 @@ import { matcher, brands } from 'name-suggestion-index'; import { actionChangePreset } from '../actions/change_preset'; import { actionChangeTags } from '../actions/change_tags'; import { actionUpgradeTags } from '../actions/upgrade_tags'; +import { osmEntity } from '../osm/entity'; import { osmIsOldMultipolygonOuterMember, osmOldMultipolygonOuterMemberOfRelation } from '../osm/multipolygon'; import { utilDisplayLabel, utilTagDiff } from '../util'; import { validationIssue, validationIssueFix } from '../core/validation'; @@ -92,7 +93,7 @@ export function validationOutdatedTags() { }, reference: showReference, entityIds: [entity.id], - hash: JSON.stringify(tagDiff), + hash: osmEntity.key(entity), fixes: [ new validationIssueFix({ autoArgs: [doUpgrade, t('issues.fix.upgrade_tags.annotation')],