From 627b4ee732d66ef750ef2725ec664d10ecc14375 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Fri, 21 Dec 2018 14:00:08 -0500 Subject: [PATCH] Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix --- modules/ui/entity_issues.js | 2 +- modules/validations/missing_tag.js | 3 ++- modules/validations/validation_issue.js | 9 +++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/modules/ui/entity_issues.js b/modules/ui/entity_issues.js index 24f5856d3..5e9b2337b 100644 --- a/modules/ui/entity_issues.js +++ b/modules/ui/entity_issues.js @@ -104,7 +104,7 @@ export function uiEntityIssues(context) { .text(function(d) { return d.title; }) - .on('click', function(d){ + .on('click', function(d) { d.action() }); } diff --git a/modules/validations/missing_tag.js b/modules/validations/missing_tag.js index 79964ff49..94e55fecb 100644 --- a/modules/validations/missing_tag.js +++ b/modules/validations/missing_tag.js @@ -42,7 +42,8 @@ export function validationMissingTag(context) { new validationIssueFix({ title: t('issues.fix.delete_feature.title'), action: function() { - operationDelete([change.id], context)(); + var id = this.issue.entities[0].id; + operationDelete([id], context)(); } }), new validationIssueFix({ diff --git a/modules/validations/validation_issue.js b/modules/validations/validation_issue.js index 8e24ac06b..421fc8de5 100644 --- a/modules/validations/validation_issue.js +++ b/modules/validations/validation_issue.js @@ -44,6 +44,13 @@ export function validationIssue(attrs) { this.entities = attrs.entities; // expect an array of entities this.coordinates = attrs.coordinates; // expect a [lon, lat] array this.fixes = attrs.fixes; // expect an array of functions for possible fixes + + if (this.fixes) { + for (var i=0; i