From 66301864c1acba0e7aa16da7918096d0a3eba0a9 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Mon, 25 Feb 2019 13:10:55 -0500 Subject: [PATCH] Fix false positive of tags suggesting area on features where other tags define the preset (close #5945, re: #5933) --- modules/validations/tag_suggests_area.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/validations/tag_suggests_area.js b/modules/validations/tag_suggests_area.js index 98507be33..b47255d42 100644 --- a/modules/validations/tag_suggests_area.js +++ b/modules/validations/tag_suggests_area.js @@ -19,9 +19,9 @@ export function validationTagSuggestsArea() { return []; } - if (context.presets().matchTags(entity.tags, 'line') === - context.presets().matchTags(entity.tags, 'area')) { - // the preset allows lines and making this an area wouldn't matter + if (context.presets().matchTags(tagSuggestingArea, 'line') === + context.presets().matchTags(tagSuggestingArea, 'area')) { + // these tags also allow lines and making this an area wouldn't matter return []; }