From 769c95af55edb322c62673e5489fac9a74084598 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Mon, 14 Oct 2019 11:03:49 +0200 Subject: [PATCH] Add non-actionable fix suggestion for "Fix Me" request issues --- data/core.yaml | 2 ++ dist/locales/en.json | 3 +++ modules/validations/help_request.js | 7 ++++++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/data/core.yaml b/data/core.yaml index cb4fb98f9..c397fe94e 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -1520,6 +1520,8 @@ en: message: '{feature} should be part of a line or area based on its tags' reference: "Some features shouldn't be standalone points." fix: + address_the_concern: + title: Address the concern connect_almost_junction: annotation: Connected very close features. connect_crossing_features: diff --git a/dist/locales/en.json b/dist/locales/en.json index f39c6a0aa..e3051e907 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1893,6 +1893,9 @@ "reference": "Some features shouldn't be standalone points." }, "fix": { + "address_the_concern": { + "title": "Address the concern" + }, "connect_almost_junction": { "annotation": "Connected very close features." }, diff --git a/modules/validations/help_request.js b/modules/validations/help_request.js index 92421b892..5abe2b521 100644 --- a/modules/validations/help_request.js +++ b/modules/validations/help_request.js @@ -1,6 +1,6 @@ import { t } from '../util/locale'; import { utilDisplayLabel } from '../util'; -import { validationIssue } from '../core/validation'; +import { validationIssue, validationIssueFix } from '../core/validation'; export function validationHelpRequest(context) { @@ -27,6 +27,11 @@ export function validationHelpRequest(context) { var entity = context.hasEntity(this.entityIds[0]); return entity ? t('issues.fixme_tag.message', { feature: utilDisplayLabel(entity, context) }) : ''; }, + fixes: [ + new validationIssueFix({ + title: t('issues.fix.address_the_concern.title') + }) + ], reference: showReference, entityIds: [entity.id] })];