Add email and website format validation

Simple validation following the HTML5 standard for emails as we don't expect POIs to have convoluted email addresses. Only checks the `website` and `email` tags as these are what iD currently supports with fields.
2026-05-15 13:38:26 +02:00 · 2019-02-26 21:16:54 +00:00
parent d42cb7b790
commit 770cffe7de
4 changed files with 96 additions and 2 deletions
@@ -0,0 +1,72 @@
+import { t } from '../util/locale';
+import { utilDisplayLabel } from '../util';
+import { validationIssue } from '../core/validation';
+
+export function validationFormatting() {
+    var type = 'invalid_format';
+
+    var validation = function(entity, context) {
+        var issues = [];
+        if (entity.tags.website) {
+            var valid_scheme = /^https?:\/\//i;
+
+            if (!valid_scheme.test(entity.tags.website)) {
+                issues.push(new validationIssue({
+                    type: type,
+                    subtype: 'website',
+                    severity: 'warning',
+                    message: function() {
+                        var entity = context.hasEntity(this.entityIds[0]);
+                        return entity ? t('issues.invalid_format.website.message', { feature: utilDisplayLabel(entity, context) }) : '';
+                    },
+                    reference: showReferenceWebsite,
+                    entityIds: [entity.id]
+                }));
+
+                function showReferenceWebsite(selection) {
+                    selection.selectAll('.issue-reference')
+                        .data([0])
+                        .enter()
+                        .append('div')
+                        .attr('class', 'issue-reference')
+                        .text(t('issues.invalid_format.website.reference'));
+                }
+            }
+        }
+
+        if (entity.tags.email) {
+            // Same regex as used by HTML5 "email" inputs
+            // Emails in OSM are going to be official so they should be pretty simple
+            var valid_email = /^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/;
+
+            if (!valid_email.test(entity.tags.email)) {
+                issues.push(new validationIssue({
+                    type: type,
+                    subtype: 'email',
+                    severity: 'warning',
+                    message: function() {
+                        var entity = context.hasEntity(this.entityIds[0]);
+                        return entity ? t('issues.invalid_format.email.message', { feature: utilDisplayLabel(entity, context) }) : '';
+                    },
+                    reference: showReferenceEmail,
+                    entityIds: [entity.id]
+                }));
+
+                function showReferenceEmail(selection) {
+                    selection.selectAll('.issue-reference')
+                        .data([0])
+                        .enter()
+                        .append('div')
+                        .attr('class', 'issue-reference')
+                        .text(t('issues.invalid_format.email.reference'));
+                }
+            }
+        }
+
+        return issues;
+    };
+
+    validation.type = type;
+
+    return validation;
+}