From 7be09db9ef37fee6ef5a2061fc364e2f9458f3c5 Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Wed, 15 May 2019 14:02:23 -0400 Subject: [PATCH] Don't try to change a key/value that's already about to be deleted (closes #6366) --- modules/ui/raw_tag_editor.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/ui/raw_tag_editor.js b/modules/ui/raw_tag_editor.js index 135369496..01217569c 100644 --- a/modules/ui/raw_tag_editor.js +++ b/modules/ui/raw_tag_editor.js @@ -455,6 +455,10 @@ export function uiRawTagEditor(context) { } _pendingChange = _pendingChange || {}; + + // exit if we are currently about to delete this row anyway - #6366 + if (_pendingChange[kOld] === undefined) return; + if (kOld) { _pendingChange[kOld] = undefined; } @@ -474,6 +478,10 @@ export function uiRawTagEditor(context) { if (isReadOnly(d)) return; _pendingChange = _pendingChange || {}; + + // exit if we are currently about to delete this row anyway - #6366 + if (_pendingChange[d.key] === undefined) return; + _pendingChange[d.key] = this.value; scheduleChange(); }