Merge branch 'master' into tyrasd-patch4968-onlyrestrictions

2026-05-31 12:19:31 +02:00 · 2018-04-10 17:28:19 -04:00
parent d2d464d9ee 997ab66e5c
commit 7ca23bf51d
108 changed files with 9884 additions and 2935 deletions
@@ -126,10 +126,17 @@ export function uiFieldCheck(field, context) {

        input
            .on('click', function() {
+                d3_event.stopPropagation();
                var t = {};
                t[field.key] = values[(values.indexOf(_value) + 1) % values.length];
+
+                // Don't cycle through `alternating` or `reversible` states - #4970
+                // (They are supported as translated strings, but should not toggle with clicks)
+                if (t[field.key] === 'reversible' || t[field.key] === 'alternating') {
+                    t[field.key] = values[0];
+                }
+
                dispatch.call('change', this, t);
-                d3_event.stopPropagation();
            });

        if (field.type === 'onewayCheck') {