From 80c7aedb390eaf695fffc12d92f58d90098c8aeb Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Tue, 29 Jan 2019 11:59:01 -0500 Subject: [PATCH] Fix bug with issues pane --- modules/ui/issues.js | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/modules/ui/issues.js b/modules/ui/issues.js index df3f4c303..2f3120fa1 100644 --- a/modules/ui/issues.js +++ b/modules/ui/issues.js @@ -18,6 +18,7 @@ export function uiIssues(context) { var key = t('issues.key'); var _featureApplicabilityList = d3_select(null); var _issuesList = d3_select(null); + var pane = d3_select(null); var _shown = false; context.issueManager().on('reload.issues_pane', update); @@ -38,6 +39,8 @@ export function uiIssues(context) { .append('ul') .attr('class', 'layer-list feature-applicability-list') .merge(_featureApplicabilityList); + + updateFeatureApplicabilityList(); } function renderIssuesList(selection) { @@ -48,6 +51,8 @@ export function uiIssues(context) { .append('ul') .attr('class', 'layer-list issues-list') .merge(_issuesList); + + updateIssuesList(); } function drawListItems(selection, data, type, name, change, active) { @@ -179,7 +184,7 @@ export function uiIssues(context) { update(); } - function update() { + function updateFeatureApplicabilityList() { _featureApplicabilityList .call( drawListItems, @@ -189,11 +194,22 @@ export function uiIssues(context) { setFeatureApplicability, showsFeatureApplicability ); + } + function updateIssuesList() { _issuesList .call(drawIssuesList); } + function update() { + if (!pane.select('.disclosure-wrap-issues_options').classed('hide')) { + updateFeatureApplicabilityList(); + } + if (!pane.select('.disclosure-wrap-issues_issues').classed('hide')) { + updateIssuesList(); + } + } + function issues(selection) { function hidePane() { @@ -237,7 +253,7 @@ export function uiIssues(context) { } } - var pane = selection + pane = selection .append('div') .attr('class', 'fillL map-pane hide');