From 820e86ad6cd9e56f0b9dc163817fcd3e0da82bf0 Mon Sep 17 00:00:00 2001 From: SilentSpike Date: Fri, 3 Jan 2020 19:48:13 +0000 Subject: [PATCH] Fix ImproveOSM request payload - Seems that the expected payload has changed so now all error types use key "targetIds" - Also includes minor fix so that comments display in the UI immediately --- modules/services/improveOSM.js | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/modules/services/improveOSM.js b/modules/services/improveOSM.js index c851fc29f..71c5f9897 100644 --- a/modules/services/improveOSM.js +++ b/modules/services/improveOSM.js @@ -361,9 +361,10 @@ export default { var that = this; d3_json(url) .then(function(data) { + // Assign directly for immediate use in the callback // comments are served newest to oldest - var comments = data.comments ? data.comments.reverse() : []; - that.replaceError(d.update({ comments: comments })); + d.comments = data.comments ? data.comments.reverse() : []; + that.replaceError(d); if (callback) callback(null, d); }) .catch(function(err) { @@ -390,18 +391,10 @@ export default { var key = d.error_key; var url = _impOsmUrls[key] + '/comment'; var payload = { - username: user.display_name + username: user.display_name, + targetIds: [ d.identifier ] }; - // Each error type has different data for identification - if (key === 'ow') { - payload.roadSegments = [ d.identifier ]; - } else if (key === 'mr') { - payload.tiles = [ d.identifier ]; - } else if (key === 'tr') { - payload.targetIds = [ d.identifier ]; - } - if (d.newStatus !== undefined) { payload.status = d.newStatus; payload.text = 'status changed';