From 84f96574d70072fb4f4ba9f877310ae11c9f4d6b Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Wed, 12 Dec 2018 02:07:03 -0500 Subject: [PATCH] Add `index` property to cloned object, not actual member object (closes #5458) This code was adding an `index` property to each member in the relation. Although the `index` property is ignored by the code that saves to OSM, the extra property would make the member changed when compared by `coreDifference`. --- modules/actions/add_member.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/actions/add_member.js b/modules/actions/add_member.js index 95874213c..854c8ef95 100644 --- a/modules/actions/add_member.js +++ b/modules/actions/add_member.js @@ -189,7 +189,7 @@ export function actionAddMember(relationId, member, memberIndex, insertPair) { function withIndex(arr) { var result = new Array(arr.length); for (var i = 0; i < arr.length; i++) { - result[i] = arr[i]; + result[i] = _clone(arr[i]); result[i].index = i; } return result;