From b2bd8ada9d4ff9c2e236c8c07c9e85f04e0fbfb9 Mon Sep 17 00:00:00 2001 From: Mert Emin Kalender Date: Sat, 7 Jan 2017 20:48:13 -0800 Subject: [PATCH 01/31] Add outdoor_seating options --- data/presets.yaml | 5 +++++ data/presets/fields.json | 9 ++++++++- data/presets/fields/outdoor_seating.json | 9 ++++++++- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/data/presets.yaml b/data/presets.yaml index ee928de9a..b738652e1 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -817,6 +817,11 @@ en: outdoor_seating: # outdoor_seating=* label: Outdoor Seating + options: + # outdoor_seating=yes + yes: Outdoor seating is possible + # outdoor_seating=no + no: No outdoor seating par: # par=* label: Par diff --git a/data/presets/fields.json b/data/presets/fields.json index 3a35f2386..a734945d2 100644 --- a/data/presets/fields.json +++ b/data/presets/fields.json @@ -1106,7 +1106,14 @@ "outdoor_seating": { "key": "outdoor_seating", "type": "combo", - "label": "Outdoor Seating" + "label": "Outdoor Seating", + "placeholder": "Yes, No...", + "strings": { + "options": { + "no": "No outdoor seating", + "yes": "Outdoor seating is possible" + } + } }, "par": { "key": "par", diff --git a/data/presets/fields/outdoor_seating.json b/data/presets/fields/outdoor_seating.json index bb80b70b7..cef5bf108 100644 --- a/data/presets/fields/outdoor_seating.json +++ b/data/presets/fields/outdoor_seating.json @@ -1,5 +1,12 @@ { "key": "outdoor_seating", "type": "combo", - "label": "Outdoor Seating" + "label": "Outdoor Seating", + "placeholder": "Yes, No...", + "strings": { + "options": { + "no": "No outdoor seating", + "yes": "Outdoor seating is possible" + } + } } From 8226745f126f461239f0ddb70a62fd85978ee763 Mon Sep 17 00:00:00 2001 From: M1dgard Date: Sun, 8 Jan 2017 23:14:29 +0100 Subject: [PATCH 02/31] Add universal email field, make fax universal Fixes #3710 --- data/presets.yaml | 5 +++++ data/presets/fields.json | 8 ++++++++ data/presets/fields/email.json | 7 +++++++ data/presets/fields/fax.json | 3 ++- dist/locales/en.json | 4 ++++ 5 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 data/presets/fields/email.json diff --git a/data/presets.yaml b/data/presets.yaml index cb0f7463d..8d1c56983 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -418,6 +418,11 @@ en: elevation: # ele=* label: Elevation + email: + # email=* + label: Email + # email field placeholder + placeholder: example@example.com emergency: # emergency=* label: Emergency diff --git a/data/presets/fields.json b/data/presets/fields.json index 3a35f2386..06c1ccef3 100644 --- a/data/presets/fields.json +++ b/data/presets/fields.json @@ -581,6 +581,13 @@ "universal": true, "label": "Elevation" }, + "email": { + "key": "email", + "type": "email", + "placeholder": "example@example.com", + "universal": true, + "label": "Email" + }, "emergency": { "key": "emergency", "type": "check", @@ -600,6 +607,7 @@ "key": "fax", "type": "tel", "label": "Fax", + "universal": true, "placeholder": "+31 42 123 4567" }, "fee": { diff --git a/data/presets/fields/email.json b/data/presets/fields/email.json new file mode 100644 index 000000000..392820199 --- /dev/null +++ b/data/presets/fields/email.json @@ -0,0 +1,7 @@ +{ + "key": "email", + "type": "email", + "placeholder": "example@example.com", + "universal": true, + "label": "Email" +} diff --git a/data/presets/fields/fax.json b/data/presets/fields/fax.json index 817661cf7..6d7228543 100644 --- a/data/presets/fields/fax.json +++ b/data/presets/fields/fax.json @@ -2,5 +2,6 @@ "key": "fax", "type": "tel", "label": "Fax", + "universal": true, "placeholder":"+31 42 123 4567" -} \ No newline at end of file +} diff --git a/dist/locales/en.json b/dist/locales/en.json index 529ae0498..a63273124 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1083,6 +1083,10 @@ "elevation": { "label": "Elevation" }, + "email": { + "label": "Email", + "placeholder": "example@example.com" + }, "emergency": { "label": "Emergency" }, From d18f54cb2f7c8d98dfcd3b132ff5a8bfa4dd40a4 Mon Sep 17 00:00:00 2001 From: Mert Emin Kalender Date: Sun, 8 Jan 2017 23:05:14 -0800 Subject: [PATCH 03/31] Making outdoor_seating checkbox --- data/presets.yaml | 5 ----- data/presets/fields.json | 11 ++--------- data/presets/fields/outdoor_seating.json | 11 ++--------- 3 files changed, 4 insertions(+), 23 deletions(-) diff --git a/data/presets.yaml b/data/presets.yaml index b738652e1..ee928de9a 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -817,11 +817,6 @@ en: outdoor_seating: # outdoor_seating=* label: Outdoor Seating - options: - # outdoor_seating=yes - yes: Outdoor seating is possible - # outdoor_seating=no - no: No outdoor seating par: # par=* label: Par diff --git a/data/presets/fields.json b/data/presets/fields.json index a734945d2..0abb4b8df 100644 --- a/data/presets/fields.json +++ b/data/presets/fields.json @@ -1105,15 +1105,8 @@ }, "outdoor_seating": { "key": "outdoor_seating", - "type": "combo", - "label": "Outdoor Seating", - "placeholder": "Yes, No...", - "strings": { - "options": { - "no": "No outdoor seating", - "yes": "Outdoor seating is possible" - } - } + "type": "check", + "label": "Outdoor Seating" }, "par": { "key": "par", diff --git a/data/presets/fields/outdoor_seating.json b/data/presets/fields/outdoor_seating.json index cef5bf108..9fe8a01bf 100644 --- a/data/presets/fields/outdoor_seating.json +++ b/data/presets/fields/outdoor_seating.json @@ -1,12 +1,5 @@ { "key": "outdoor_seating", - "type": "combo", - "label": "Outdoor Seating", - "placeholder": "Yes, No...", - "strings": { - "options": { - "no": "No outdoor seating", - "yes": "Outdoor seating is possible" - } - } + "type": "check", + "label": "Outdoor Seating" } From c6540336634d1280059878654af6160ccca7fe31 Mon Sep 17 00:00:00 2001 From: Mert Emin Kalender Date: Sun, 8 Jan 2017 23:36:21 -0800 Subject: [PATCH 04/31] Add Turkish phone format --- data/phone-formats.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/phone-formats.json b/data/phone-formats.json index 0403866ec..4bb2e19a9 100644 --- a/data/phone-formats.json +++ b/data/phone-formats.json @@ -50,6 +50,7 @@ "kz": "+7 495 1234567", "vn": "+84 1 234 5678", "hk": "+852 1234 5678", - "tw": "+886 1 2345 6789" + "tw": "+886 1 2345 6789", + "tr": "+90 312 213 2965" } } From ef54e4eb8ec4415202ef96b8e5efd35010f753cd Mon Sep 17 00:00:00 2001 From: boothym Date: Tue, 10 Jan 2017 15:46:50 +0000 Subject: [PATCH 05/31] Add step_count field --- data/presets/fields.json | 5 +++++ data/presets/fields/step_count.json | 5 +++++ data/presets/presets.json | 3 ++- data/presets/presets/highway/steps.json | 3 ++- 4 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 data/presets/fields/step_count.json diff --git a/data/presets/fields.json b/data/presets/fields.json index 3a35f2386..415bed22e 100644 --- a/data/presets/fields.json +++ b/data/presets/fields.json @@ -1481,6 +1481,11 @@ "type": "number", "label": "Stars" }, + "step_count": { + "key": "step_count", + "type": "number", + "label": "Number of Steps" + }, "stop": { "key": "stop", "type": "combo", diff --git a/data/presets/fields/step_count.json b/data/presets/fields/step_count.json new file mode 100644 index 000000000..23eebe7ff --- /dev/null +++ b/data/presets/fields/step_count.json @@ -0,0 +1,5 @@ +{ + "key": "step_count", + "type": "number", + "label": "Number of Steps" +} diff --git a/data/presets/presets.json b/data/presets/presets.json index 8b89f52ad..fe29c8993 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -5419,7 +5419,8 @@ "lit", "width", "incline_steps", - "handrail" + "handrail", + "step_count" ], "icon": "highway-steps", "geometry": [ diff --git a/data/presets/presets/highway/steps.json b/data/presets/presets/highway/steps.json index 9c94bfa58..a8d766ed1 100644 --- a/data/presets/presets/highway/steps.json +++ b/data/presets/presets/highway/steps.json @@ -4,7 +4,8 @@ "lit", "width", "incline_steps", - "handrail" + "handrail", + "step_count" ], "icon": "highway-steps", "geometry": [ From 1207b08a209d69c057fdad9a91155668cd802bbf Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Tue, 10 Jan 2017 22:57:25 +0530 Subject: [PATCH 06/31] Use a more example-y Turkish phone number, and run build --- data/phone-formats.json | 2 +- data/presets.yaml | 3 +++ dist/locales/en.json | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/data/phone-formats.json b/data/phone-formats.json index 4bb2e19a9..502cad54c 100644 --- a/data/phone-formats.json +++ b/data/phone-formats.json @@ -51,6 +51,6 @@ "vn": "+84 1 234 5678", "hk": "+852 1234 5678", "tw": "+886 1 2345 6789", - "tr": "+90 312 213 2965" + "tr": "+90 312 123 4567" } } diff --git a/data/presets.yaml b/data/presets.yaml index cb0f7463d..f52198ece 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -1099,6 +1099,9 @@ en: stars: # stars=* label: Stars + step_count: + # step_count=* + label: Number of Steps stop: # stop=* label: Stop Type diff --git a/dist/locales/en.json b/dist/locales/en.json index 529ae0498..10e1c7813 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1640,6 +1640,9 @@ "stars": { "label": "Stars" }, + "step_count": { + "label": "Number of Steps" + }, "stop": { "label": "Stop Type", "options": { From adbde8c68faf6c48e39eb635e33de6a3a6ba6f20 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Thu, 12 Jan 2017 14:37:21 +0530 Subject: [PATCH 07/31] Add additional aerialway presets, fixes #3733 --- data/presets.yaml | 12 ++++++ data/presets/presets.json | 42 +++++++++++++++++++ data/presets/presets/aerialway/drag_lift.json | 13 ++++++ data/presets/presets/aerialway/goods.json | 13 ++++++ .../presets/presets/aerialway/mixed_lift.json | 16 +++++++ data/taginfo.json | 12 ++++++ dist/locales/en.json | 12 ++++++ 7 files changed, 120 insertions(+) create mode 100644 data/presets/presets/aerialway/drag_lift.json create mode 100644 data/presets/presets/aerialway/goods.json create mode 100644 data/presets/presets/aerialway/mixed_lift.json diff --git a/data/presets.yaml b/data/presets.yaml index b80f4ea52..a0258fc1c 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -1312,14 +1312,26 @@ en: # aerialway=chair_lift name: Chair Lift terms: '' + aerialway/drag_lift: + # aerialway=drag_lift + name: Drag Lift + terms: '' aerialway/gondola: # aerialway=gondola name: Gondola terms: '' + aerialway/goods: + # aerialway=goods + name: Goods + terms: '' aerialway/magic_carpet: # aerialway=magic_carpet name: Magic Carpet Lift terms: '' + aerialway/mixed_lift: + # aerialway=mixed_lift + name: Mixed Lift + terms: '' aerialway/platter: # aerialway=platter name: Platter Lift diff --git a/data/presets/presets.json b/data/presets/presets.json index fe29c8993..c271ecd18 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -207,6 +207,19 @@ }, "name": "Chair Lift" }, + "aerialway/drag_lift": { + "geometry": [ + "line" + ], + "fields": [ + "aerialway/capacity", + "aerialway/duration" + ], + "tags": { + "aerialway": "drag_lift" + }, + "name": "Drag Lift" + }, "aerialway/gondola": { "geometry": [ "line" @@ -223,6 +236,19 @@ }, "name": "Gondola" }, + "aerialway/goods": { + "geometry": [ + "line" + ], + "fields": [ + "aerialway/capacity", + "aerialway/duration" + ], + "tags": { + "aerialway": "goods" + }, + "name": "Goods" + }, "aerialway/magic_carpet": { "geometry": [ "line" @@ -237,6 +263,22 @@ }, "name": "Magic Carpet Lift" }, + "aerialway/mixed_lift": { + "geometry": [ + "line" + ], + "fields": [ + "aerialway/occupancy", + "aerialway/capacity", + "aerialway/duration", + "aerialway/bubble", + "aerialway/heating" + ], + "tags": { + "aerialway": "mixed_lift" + }, + "name": "Mixed Lift" + }, "aerialway/platter": { "geometry": [ "line" diff --git a/data/presets/presets/aerialway/drag_lift.json b/data/presets/presets/aerialway/drag_lift.json new file mode 100644 index 000000000..d10b15c96 --- /dev/null +++ b/data/presets/presets/aerialway/drag_lift.json @@ -0,0 +1,13 @@ +{ + "geometry": [ + "line" + ], + "fields": [ + "aerialway/capacity", + "aerialway/duration" + ], + "tags": { + "aerialway": "drag_lift" + }, + "name": "Drag Lift" +} diff --git a/data/presets/presets/aerialway/goods.json b/data/presets/presets/aerialway/goods.json new file mode 100644 index 000000000..0ed598a1c --- /dev/null +++ b/data/presets/presets/aerialway/goods.json @@ -0,0 +1,13 @@ +{ + "geometry": [ + "line" + ], + "fields": [ + "aerialway/capacity", + "aerialway/duration" + ], + "tags": { + "aerialway": "goods" + }, + "name": "Goods" +} diff --git a/data/presets/presets/aerialway/mixed_lift.json b/data/presets/presets/aerialway/mixed_lift.json new file mode 100644 index 000000000..d8ddb6417 --- /dev/null +++ b/data/presets/presets/aerialway/mixed_lift.json @@ -0,0 +1,16 @@ +{ + "geometry": [ + "line" + ], + "fields": [ + "aerialway/occupancy", + "aerialway/capacity", + "aerialway/duration", + "aerialway/bubble", + "aerialway/heating" + ], + "tags": { + "aerialway": "mixed_lift" + }, + "name": "Mixed Lift" +} diff --git a/data/taginfo.json b/data/taginfo.json index 14ed9dc67..556ee3110 100644 --- a/data/taginfo.json +++ b/data/taginfo.json @@ -55,14 +55,26 @@ "key": "aerialway", "value": "chair_lift" }, + { + "key": "aerialway", + "value": "drag_lift" + }, { "key": "aerialway", "value": "gondola" }, + { + "key": "aerialway", + "value": "goods" + }, { "key": "aerialway", "value": "magic_carpet" }, + { + "key": "aerialway", + "value": "mixed_lift" + }, { "key": "aerialway", "value": "platter" diff --git a/dist/locales/en.json b/dist/locales/en.json index aae4ab37a..ed981101a 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1856,14 +1856,26 @@ "name": "Chair Lift", "terms": "" }, + "aerialway/drag_lift": { + "name": "Drag Lift", + "terms": "" + }, "aerialway/gondola": { "name": "Gondola", "terms": "" }, + "aerialway/goods": { + "name": "Goods", + "terms": "" + }, "aerialway/magic_carpet": { "name": "Magic Carpet Lift", "terms": "" }, + "aerialway/mixed_lift": { + "name": "Mixed Lift", + "terms": "" + }, "aerialway/platter": { "name": "Platter Lift", "terms": "button lift,poma lift" From 0b63eaa245e0d3d118211bc54bc290d4ac204739 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 11:09:24 +0530 Subject: [PATCH 08/31] Update maki package to version 2 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index cf2362145..63dd55454 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,7 @@ "js-yaml": "~3.7.0", "jsonschema": "~1.1.0", "json-stable-stringify": "~1.0.1", - "maki": "0.5.0", + "maki": "^2.1.0", "mapillary-js": "2.2.0", "minimist": "~1.2.0", "mocha": "~3.2.0", From 7f9702f4bc0576820dae563dc2aedb78d8808bf7 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 11:12:37 +0530 Subject: [PATCH 09/31] Update path in dist:svg:maki script --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 63dd55454..4ff3a253f 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "dist:css": "shx cat css/reset.css css/map.css css/app.css > dist/iD.css", "dist:mapillary": "shx mkdir -p dist/mapillary-js && shx cp -R node_modules/mapillary-js/dist/* dist/mapillary-js/", "dist:min": "uglifyjs dist/iD.js -c -m -o dist/iD.min.js", - "dist:svg:maki": "svg-sprite --symbol --symbol-dest . --symbol-sprite dist/img/maki-sprite.svg node_modules/maki/src/*.svg", + "dist:svg:maki": "svg-sprite --symbol --symbol-dest . --symbol-sprite dist/img/maki-sprite.svg node_modules/maki/icons/*.svg", "dist:svg:id": "node svg/spriteify.js --svg svg/iD-sprite.src.svg --json svg/iD-sprite.json > dist/img/iD-sprite.svg", "imagery": "node data/update_imagery", "lint": "eslint *.js js/id test/spec modules", From 44034d051bf3f4a65d51830b13d8445313a25151 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 14:42:24 +0530 Subject: [PATCH 10/31] Pull in @mapbox/maki instead --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 4ff3a253f..4a5a93d9f 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "dist:css": "shx cat css/reset.css css/map.css css/app.css > dist/iD.css", "dist:mapillary": "shx mkdir -p dist/mapillary-js && shx cp -R node_modules/mapillary-js/dist/* dist/mapillary-js/", "dist:min": "uglifyjs dist/iD.js -c -m -o dist/iD.min.js", - "dist:svg:maki": "svg-sprite --symbol --symbol-dest . --symbol-sprite dist/img/maki-sprite.svg node_modules/maki/icons/*.svg", + "dist:svg:maki": "svg-sprite --symbol --symbol-dest . --symbol-sprite dist/img/maki-sprite.svg node_modules/@mapbox/maki/icons/*.svg", "dist:svg:id": "node svg/spriteify.js --svg svg/iD-sprite.src.svg --json svg/iD-sprite.json > dist/img/iD-sprite.svg", "imagery": "node data/update_imagery", "lint": "eslint *.js js/id test/spec modules", @@ -38,6 +38,7 @@ "wmf-sitematrix": "0.1.3" }, "devDependencies": { + "@mapbox/maki": "^4.0.0", "brfs": "1.4.3", "chai": "~3.5.0", "d3": "4.4.1", @@ -50,7 +51,6 @@ "js-yaml": "~3.7.0", "jsonschema": "~1.1.0", "json-stable-stringify": "~1.0.1", - "maki": "^2.1.0", "mapillary-js": "2.2.0", "minimist": "~1.2.0", "mocha": "~3.2.0", @@ -74,7 +74,7 @@ "xmlbuilder": "~8.2.2" }, "greenkeeper": { - "ignore": ["maki"], + "ignore": ["@mapbox/maki"], "label": "chore-greenkeeper" }, "engines": { From 953ca7cfc6a018f6f38d6c980c68ade31224715b Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:04:27 +0530 Subject: [PATCH 11/31] Get the list of maki icons --- data/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/data/index.js b/data/index.js index 3387e7524..1fc44aaff 100644 --- a/data/index.js +++ b/data/index.js @@ -1,5 +1,4 @@ export { wikipedia as dataWikipedia } from 'wmf-sitematrix'; -export { default as dataFeatureIcons } from 'maki/www/maki-sprite.json'; export { default as dataSuggestions } from 'name-suggestion-index/name-suggestions.json'; export { dataAddressFormats } from './address-formats.json'; @@ -18,6 +17,9 @@ import { defaults } from './presets/defaults.json'; import { categories } from './presets/categories.json'; import { fields } from './presets/fields.json'; +import maki from '@mapbox/maki'; +export var dataFeatureIcons = maki.layouts.all.all; + export var data = { imagery: dataImagery, presets: { From 3379d5d9ba26c62937f7f5709b3faf8943dc413f Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:04:58 +0530 Subject: [PATCH 12/31] Fix isMaki, reset sizes, remove unnecessary checks --- modules/svg/points.js | 8 ++++---- modules/ui/preset_icon.js | 10 +++------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/modules/svg/points.js b/modules/svg/points.js index a47de75f6..ea09d3e4a 100644 --- a/modules/svg/points.js +++ b/modules/svg/points.js @@ -46,10 +46,10 @@ export function svgPoints(projection, context) { .call(markerPath, 'stroke'); enter.append('use') - .attr('transform', 'translate(-6, -20)') + .attr('transform', 'translate(-5, -19)') .attr('class', 'icon') - .attr('width', '12px') - .attr('height', '12px'); + .attr('width', '11px') + .attr('height', '11px'); groups = groups .merge(enter) @@ -63,7 +63,7 @@ export function svgPoints(projection, context) { groups.select('.icon') .attr('xlink:href', function(entity) { var preset = context.presets().match(entity, graph); - return (preset && preset.icon) ? '#' + preset.icon + '-12' : ''; + return (preset && preset.icon) ? '#' + preset.icon + '-11' : ''; }); }; } diff --git a/modules/ui/preset_icon.js b/modules/ui/preset_icon.js index 737484b02..9fb02427e 100644 --- a/modules/ui/preset_icon.js +++ b/modules/ui/preset_icon.js @@ -18,11 +18,7 @@ export function uiPresetIcon() { p = preset.apply(this, arguments), geom = geometry.apply(this, arguments), picon = p.icon || (geom === 'line' ? 'other-line' : 'marker-stroked'), - isMaki = dataFeatureIcons.hasOwnProperty(picon + '-24'); - - if (picon === 'dentist') { - isMaki = true; // workaround for dentist icon missing in `maki-sprite.json` - } + isMaki = dataFeatureIcons.indexOf(picon) !== -1; function tag_classes(p) { var s = ''; @@ -78,8 +74,8 @@ export function uiPresetIcon() { return 'icon ' + picon + tag_classes(p); }); - icon.selectAll('use') // workaround: maki parking-24 broken? - .attr('href', '#' + picon + (isMaki ? (picon === 'parking' ? '-18' : '-24') : '')); + icon.selectAll('use') + .attr('href', '#' + picon + (isMaki ? '-15' : '')); } From 7b87e450b4ddc525bf37c45f10c8546aa223a522 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:13:46 +0530 Subject: [PATCH 13/31] Rename camera to attraction --- data/presets/presets.json | 10 +++++----- data/presets/presets/craft/photographer.json | 2 +- .../presets/presets/craft/photographic_laboratory.json | 2 +- data/presets/presets/man_made/surveillance.json | 2 +- data/presets/presets/man_made/surveillance_camera.json | 2 +- data/presets/presets/shop/photo.json | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index c271ecd18..9cd8b0485 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -4065,7 +4065,7 @@ "name": "Painter" }, "craft/photographer": { - "icon": "camera", + "icon": "attraction", "fields": [ "operator", "address", @@ -4082,7 +4082,7 @@ "name": "Photographer" }, "craft/photographic_laboratory": { - "icon": "camera", + "icon": "attraction", "fields": [ "operator", "address", @@ -7569,7 +7569,7 @@ "name": "Storage Tank" }, "man_made/surveillance_camera": { - "icon": "camera", + "icon": "attraction", "geometry": [ "point" ], @@ -7603,7 +7603,7 @@ "name": "Surveillance Camera" }, "man_made/surveillance": { - "icon": "camera", + "icon": "attraction", "geometry": [ "point" ], @@ -10914,7 +10914,7 @@ "name": "Pet Store" }, "shop/photo": { - "icon": "camera", + "icon": "attraction", "fields": [ "operator", "address", diff --git a/data/presets/presets/craft/photographer.json b/data/presets/presets/craft/photographer.json index f9600d258..b1fb78aba 100644 --- a/data/presets/presets/craft/photographer.json +++ b/data/presets/presets/craft/photographer.json @@ -1,5 +1,5 @@ { - "icon": "camera", + "icon": "attraction", "fields": [ "operator", "address", diff --git a/data/presets/presets/craft/photographic_laboratory.json b/data/presets/presets/craft/photographic_laboratory.json index e6ebbe905..9efe88bb5 100644 --- a/data/presets/presets/craft/photographic_laboratory.json +++ b/data/presets/presets/craft/photographic_laboratory.json @@ -1,5 +1,5 @@ { - "icon": "camera", + "icon": "attraction", "fields": [ "operator", "address", diff --git a/data/presets/presets/man_made/surveillance.json b/data/presets/presets/man_made/surveillance.json index ee2a07e80..ddbf3ba8e 100644 --- a/data/presets/presets/man_made/surveillance.json +++ b/data/presets/presets/man_made/surveillance.json @@ -1,5 +1,5 @@ { - "icon": "camera", + "icon": "attraction", "geometry": [ "point" ], diff --git a/data/presets/presets/man_made/surveillance_camera.json b/data/presets/presets/man_made/surveillance_camera.json index 10aea0a2b..6417d5840 100644 --- a/data/presets/presets/man_made/surveillance_camera.json +++ b/data/presets/presets/man_made/surveillance_camera.json @@ -1,5 +1,5 @@ { - "icon": "camera", + "icon": "attraction", "geometry": [ "point" ], diff --git a/data/presets/presets/shop/photo.json b/data/presets/presets/shop/photo.json index 03d246b03..6c09a6fd3 100644 --- a/data/presets/presets/shop/photo.json +++ b/data/presets/presets/shop/photo.json @@ -1,5 +1,5 @@ { - "icon": "camera", + "icon": "attraction", "fields": [ "operator", "address", From 6ece90b80af46ffebafd78a03d5dcaef96189af3 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:35:22 +0530 Subject: [PATCH 14/31] Rename mobilephone to mobile-phone & emergency-telephone to emergency-phone --- data/presets/presets.json | 46 ++++++++++----------- data/presets/presets/emergency/phone.json | 4 +- data/presets/presets/shop/mobile_phone.json | 2 +- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 9cd8b0485..89c0b4a4d 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -4587,7 +4587,7 @@ "name": "Fire Hydrant" }, "emergency/phone": { - "icon": "emergency-telephone", + "icon": "emergency-phone", "fields": [ "operator" ], @@ -10645,7 +10645,7 @@ "name": "Medical Supply Store" }, "shop/mobile_phone": { - "icon": "mobilephone", + "icon": "mobile-phone", "fields": [ "operator", "address", @@ -41277,7 +41277,7 @@ "shop": "mobile_phone" }, "name": "Билайн", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41296,7 +41296,7 @@ "shop": "mobile_phone" }, "name": "ソフトバンクショップ (SoftBank shop)", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41315,7 +41315,7 @@ "shop": "mobile_phone" }, "name": "Vodafone", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41334,7 +41334,7 @@ "shop": "mobile_phone" }, "name": "O2", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41353,7 +41353,7 @@ "shop": "mobile_phone" }, "name": "Carphone Warehouse", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41372,7 +41372,7 @@ "shop": "mobile_phone" }, "name": "Orange", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41391,7 +41391,7 @@ "shop": "mobile_phone" }, "name": "Verizon Wireless", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41410,7 +41410,7 @@ "shop": "mobile_phone" }, "name": "Sprint", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41429,7 +41429,7 @@ "shop": "mobile_phone" }, "name": "T-Mobile", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41448,7 +41448,7 @@ "shop": "mobile_phone" }, "name": "МТС", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41467,7 +41467,7 @@ "shop": "mobile_phone" }, "name": "Евросеть", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41486,7 +41486,7 @@ "shop": "mobile_phone" }, "name": "Bell", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41505,7 +41505,7 @@ "shop": "mobile_phone" }, "name": "The Phone House", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41524,7 +41524,7 @@ "shop": "mobile_phone" }, "name": "SFR", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41543,7 +41543,7 @@ "shop": "mobile_phone" }, "name": "Связной", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41562,7 +41562,7 @@ "shop": "mobile_phone" }, "name": "Мегафон", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41581,7 +41581,7 @@ "shop": "mobile_phone" }, "name": "AT&T", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41600,7 +41600,7 @@ "shop": "mobile_phone" }, "name": "ドコモショップ (docomo shop)", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41619,7 +41619,7 @@ "shop": "mobile_phone" }, "name": "au", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41638,7 +41638,7 @@ "shop": "mobile_phone" }, "name": "Movistar", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" @@ -41657,7 +41657,7 @@ "shop": "mobile_phone" }, "name": "Bitė", - "icon": "mobilephone", + "icon": "mobile-phone", "geometry": [ "point", "area" diff --git a/data/presets/presets/emergency/phone.json b/data/presets/presets/emergency/phone.json index aea4c5d18..75be91b2e 100644 --- a/data/presets/presets/emergency/phone.json +++ b/data/presets/presets/emergency/phone.json @@ -1,5 +1,5 @@ { - "icon": "emergency-telephone", + "icon": "emergency-phone", "fields": [ "operator" ], @@ -11,4 +11,4 @@ "emergency": "phone" }, "name": "Emergency Phone" -} \ No newline at end of file +} diff --git a/data/presets/presets/shop/mobile_phone.json b/data/presets/presets/shop/mobile_phone.json index 45b11be72..686f57f12 100644 --- a/data/presets/presets/shop/mobile_phone.json +++ b/data/presets/presets/shop/mobile_phone.json @@ -1,5 +1,5 @@ { - "icon": "mobilephone", + "icon": "mobile-phone", "fields": [ "operator", "address", From d5c1900006b753cb91c0ffad42f22673e395984c Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:39:56 +0530 Subject: [PATCH 15/31] Rename industrial to industry --- data/presets/presets.json | 8 ++++---- data/presets/presets/building/industrial.json | 2 +- data/presets/presets/landuse/industrial.json | 2 +- data/presets/presets/man_made/works.json | 2 +- data/presets/presets/power/plant.json | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 89c0b4a4d..282188aa9 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -3319,7 +3319,7 @@ "name": "Hut" }, "building/industrial": { - "icon": "industrial", + "icon": "industry", "fields": [ "address", "levels" @@ -6039,7 +6039,7 @@ "name": "Grass" }, "landuse/industrial": { - "icon": "industrial", + "icon": "industry", "geometry": [ "area" ], @@ -7723,7 +7723,7 @@ "name": "Water Works" }, "man_made/works": { - "icon": "industrial", + "icon": "industry", "fields": [ "operator", "address", @@ -8820,7 +8820,7 @@ "name": "Minor Power Line" }, "power/plant": { - "icon": "industrial", + "icon": "industry", "fields": [ "operator" ], diff --git a/data/presets/presets/building/industrial.json b/data/presets/presets/building/industrial.json index 19d8a4e54..53a2d5eb4 100644 --- a/data/presets/presets/building/industrial.json +++ b/data/presets/presets/building/industrial.json @@ -1,5 +1,5 @@ { - "icon": "industrial", + "icon": "industry", "fields": [ "address", "levels" diff --git a/data/presets/presets/landuse/industrial.json b/data/presets/presets/landuse/industrial.json index 11eadfceb..9972d26c0 100644 --- a/data/presets/presets/landuse/industrial.json +++ b/data/presets/presets/landuse/industrial.json @@ -1,5 +1,5 @@ { - "icon": "industrial", + "icon": "industry", "geometry": [ "area" ], diff --git a/data/presets/presets/man_made/works.json b/data/presets/presets/man_made/works.json index 6f6ac809f..54d41bd05 100644 --- a/data/presets/presets/man_made/works.json +++ b/data/presets/presets/man_made/works.json @@ -1,5 +1,5 @@ { - "icon": "industrial", + "icon": "industry", "fields": [ "operator", "address", diff --git a/data/presets/presets/power/plant.json b/data/presets/presets/power/plant.json index 62d876407..8a9d417b4 100644 --- a/data/presets/presets/power/plant.json +++ b/data/presets/presets/power/plant.json @@ -1,5 +1,5 @@ { - "icon": "industrial", + "icon": "industry", "fields": [ "operator" ], From 781f4540e0dc3fb6803e4fa84d7d0744b6b68b0c Mon Sep 17 00:00:00 2001 From: Kushan Joshi <0o3ko0@gmail.com> Date: Fri, 13 Jan 2017 15:42:03 +0530 Subject: [PATCH 16/31] Add a pluggable geocoder --- modules/services/index.js | 2 +- modules/services/nominatim.js | 5 +++++ modules/ui/feature_list.js | 9 +++++---- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/modules/services/index.js b/modules/services/index.js index 1f20acbc5..ea8f600c7 100644 --- a/modules/services/index.js +++ b/modules/services/index.js @@ -7,7 +7,7 @@ import serviceWikipedia from './wikipedia'; export var services = { mapillary: serviceMapillary, - nominatim: serviceNominatim, + geocoder: serviceNominatim, osm: serviceOsm, taginfo: serviceTaginfo, wikidata: serviceWikidata, diff --git a/modules/services/nominatim.js b/modules/services/nominatim.js index c1277f72a..d17d9cb8e 100644 --- a/modules/services/nominatim.js +++ b/modules/services/nominatim.js @@ -43,6 +43,11 @@ export default { callback(null, result.address.country_code); } ); + }, + + search: function (val, callback) { + var searchVal = encodeURIComponent(val); + d3.json('https://nominatim.openstreetmap.org/search/' + searchVal + '?limit=10&format=json', callback); } }; diff --git a/modules/ui/feature_list.js b/modules/ui/feature_list.js index 68d9dc616..f5e27572d 100644 --- a/modules/ui/feature_list.js +++ b/modules/ui/feature_list.js @@ -5,6 +5,8 @@ import { geoExtent, geoChooseEdge } from '../geo/index'; import { modeSelect } from '../modes/index'; import { osmEntity } from '../osm/index'; import { svgIcon } from '../svg/index'; +import { services } from '../services/index'; + import { utilDisplayName, utilDisplayType, @@ -181,7 +183,7 @@ export function uiFeatureList(context) { .data([0]) .enter().append('button') .attr('class', 'geocode-item') - .on('click', geocode) + .on('click', geocoderSearch) .append('div') .attr('class', 'label') .append('span') @@ -270,9 +272,8 @@ export function uiFeatureList(context) { } - function geocode() { - var searchVal = encodeURIComponent(search.property('value')); - d3.json('https://nominatim.openstreetmap.org/search/' + searchVal + '?limit=10&format=json', function(err, resp) { + function geocoderSearch() { + services.geocoder.search(search.property('value'), function (err, resp) { geocodeResults = resp || []; drawList(); }); From 8e6ca56e2f49722fcf54c639e9c058521a7a54ac Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:50:40 +0530 Subject: [PATCH 17/31] Rename park2 to park-alt; set sawmill as logging --- data/presets/presets.json | 8 ++++---- data/presets/presets/craft/sawmill.json | 2 +- data/presets/presets/landuse/forest.json | 2 +- data/presets/presets/landuse/orchard.json | 2 +- data/presets/presets/natural/wood.json | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 282188aa9..9a640b0ce 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -4227,7 +4227,7 @@ "name": "Sailmaker" }, "craft/sawmill": { - "icon": "park", + "icon": "logging", "fields": [ "operator", "address", @@ -6002,7 +6002,7 @@ "name": "Farmyard" }, "landuse/forest": { - "icon": "park2", + "icon": "park-alt1", "fields": [ "leaf_type", "leaf_cycle" @@ -6452,7 +6452,7 @@ "name": "Training Area" }, "landuse/orchard": { - "icon": "park2", + "icon": "park-alt1", "fields": [ "operator", "trees" @@ -8127,7 +8127,7 @@ "name": "Wetland" }, "natural/wood": { - "icon": "park2", + "icon": "park-alt1", "fields": [ "leaf_type", "leaf_cycle" diff --git a/data/presets/presets/craft/sawmill.json b/data/presets/presets/craft/sawmill.json index a2da42fb0..1f2efab66 100644 --- a/data/presets/presets/craft/sawmill.json +++ b/data/presets/presets/craft/sawmill.json @@ -1,5 +1,5 @@ { - "icon": "park", + "icon": "logging", "fields": [ "operator", "address", diff --git a/data/presets/presets/landuse/forest.json b/data/presets/presets/landuse/forest.json index 9c0dd25e4..4ba07c081 100644 --- a/data/presets/presets/landuse/forest.json +++ b/data/presets/presets/landuse/forest.json @@ -1,5 +1,5 @@ { - "icon": "park2", + "icon": "park-alt1", "fields": [ "leaf_type", "leaf_cycle" diff --git a/data/presets/presets/landuse/orchard.json b/data/presets/presets/landuse/orchard.json index 35607bfb1..a5842d79a 100644 --- a/data/presets/presets/landuse/orchard.json +++ b/data/presets/presets/landuse/orchard.json @@ -1,5 +1,5 @@ { - "icon": "park2", + "icon": "park-alt1", "fields": [ "operator", "trees" diff --git a/data/presets/presets/natural/wood.json b/data/presets/presets/natural/wood.json index f8ab42d78..ec6931c2e 100644 --- a/data/presets/presets/natural/wood.json +++ b/data/presets/presets/natural/wood.json @@ -1,5 +1,5 @@ { - "icon": "park2", + "icon": "park-alt1", "fields": [ "leaf_type", "leaf_cycle" From 71a14a9798bad0aded1b43721f2d54f2a0df5c5c Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 15:53:31 +0530 Subject: [PATCH 18/31] Rename land-use to landuse --- data/presets/categories.json | 2 +- data/presets/categories/landuse.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/presets/categories.json b/data/presets/categories.json index 4cdc1beb6..be59ba85e 100644 --- a/data/presets/categories.json +++ b/data/presets/categories.json @@ -42,7 +42,7 @@ "category-landuse": { "geometry": "area", "name": "Land Use Features", - "icon": "land-use", + "icon": "landuse", "members": [ "landuse/residential", "landuse/industrial", diff --git a/data/presets/categories/landuse.json b/data/presets/categories/landuse.json index e7d1c2ece..fc66cfd57 100644 --- a/data/presets/categories/landuse.json +++ b/data/presets/categories/landuse.json @@ -1,7 +1,7 @@ { "geometry": "area", "name": "Land Use Features", - "icon": "land-use", + "icon": "landuse", "members": [ "landuse/residential", "landuse/industrial", From 33a4ffd213ab2d2ff79359033e3e85ddacf5114c Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:02:05 +0530 Subject: [PATCH 19/31] Rename toilets to toilet --- data/presets/presets.json | 2 +- data/presets/presets/amenity/toilets.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 9a640b0ce..741f9c599 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -2315,7 +2315,7 @@ "name": "Theater" }, "amenity/toilets": { - "icon": "toilets", + "icon": "toilet", "fields": [ "toilets/disposal", "operator", diff --git a/data/presets/presets/amenity/toilets.json b/data/presets/presets/amenity/toilets.json index 5d8fa0764..38273f24b 100644 --- a/data/presets/presets/amenity/toilets.json +++ b/data/presets/presets/amenity/toilets.json @@ -1,5 +1,5 @@ { - "icon": "toilets", + "icon": "toilet", "fields": [ "toilets/disposal", "operator", From c9718df21476dac505889d505375688f69d22fd6 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:08:55 +0530 Subject: [PATCH 20/31] Use barrier instead of prison --- data/presets/presets.json | 12 ++++++------ data/presets/presets/barrier/cattle_grid.json | 2 +- data/presets/presets/barrier/city_wall.json | 2 +- data/presets/presets/barrier/fence.json | 2 +- data/presets/presets/barrier/gate.json | 2 +- data/presets/presets/barrier/kissing_gate.json | 2 +- data/presets/presets/barrier/wall.json | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 741f9c599..082f87b5e 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -2788,7 +2788,7 @@ "name": "Border Control" }, "barrier/cattle_grid": { - "icon": "prison", + "icon": "barrier", "geometry": [ "vertex" ], @@ -2798,7 +2798,7 @@ "name": "Cattle Grid" }, "barrier/city_wall": { - "icon": "prison", + "icon": "barrier", "fields": [ "height" ], @@ -2837,7 +2837,7 @@ "matchScore": 0.25 }, "barrier/fence": { - "icon": "prison", + "icon": "barrier", "fields": [ "fence_type", "height" @@ -2852,7 +2852,7 @@ "matchScore": 0.25 }, "barrier/gate": { - "icon": "prison", + "icon": "barrier", "fields": [ "access" ], @@ -2881,7 +2881,7 @@ "matchScore": 0.25 }, "barrier/kissing_gate": { - "icon": "prison", + "icon": "barrier", "fields": [ "access" ], @@ -2947,7 +2947,7 @@ "name": "Toll Booth" }, "barrier/wall": { - "icon": "prison", + "icon": "barrier", "fields": [ "wall", "height" diff --git a/data/presets/presets/barrier/cattle_grid.json b/data/presets/presets/barrier/cattle_grid.json index 6e7c8cde7..6bc9901f4 100644 --- a/data/presets/presets/barrier/cattle_grid.json +++ b/data/presets/presets/barrier/cattle_grid.json @@ -1,5 +1,5 @@ { - "icon": "prison", + "icon": "barrier", "geometry": [ "vertex" ], diff --git a/data/presets/presets/barrier/city_wall.json b/data/presets/presets/barrier/city_wall.json index 6d69be4de..4e57b4faa 100644 --- a/data/presets/presets/barrier/city_wall.json +++ b/data/presets/presets/barrier/city_wall.json @@ -1,5 +1,5 @@ { - "icon": "prison", + "icon": "barrier", "fields": [ "height" ], diff --git a/data/presets/presets/barrier/fence.json b/data/presets/presets/barrier/fence.json index 0da24b3a2..7576ecb9d 100644 --- a/data/presets/presets/barrier/fence.json +++ b/data/presets/presets/barrier/fence.json @@ -1,5 +1,5 @@ { - "icon": "prison", + "icon": "barrier", "fields": [ "fence_type", "height" diff --git a/data/presets/presets/barrier/gate.json b/data/presets/presets/barrier/gate.json index 7ba3d2b85..fd63d0a3d 100644 --- a/data/presets/presets/barrier/gate.json +++ b/data/presets/presets/barrier/gate.json @@ -1,5 +1,5 @@ { - "icon": "prison", + "icon": "barrier", "fields": [ "access" ], diff --git a/data/presets/presets/barrier/kissing_gate.json b/data/presets/presets/barrier/kissing_gate.json index 181ad18d7..b67cfa0e8 100644 --- a/data/presets/presets/barrier/kissing_gate.json +++ b/data/presets/presets/barrier/kissing_gate.json @@ -1,5 +1,5 @@ { - "icon": "prison", + "icon": "barrier", "fields": [ "access" ], diff --git a/data/presets/presets/barrier/wall.json b/data/presets/presets/barrier/wall.json index 4b1bb4518..4a523842d 100644 --- a/data/presets/presets/barrier/wall.json +++ b/data/presets/presets/barrier/wall.json @@ -1,5 +1,5 @@ { - "icon": "prison", + "icon": "barrier", "fields": [ "wall", "height" From 16be07a7ccee77859a20007ab3ded143aa1c65b9 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:11:18 +0530 Subject: [PATCH 21/31] Use fence --- data/presets/presets.json | 2 +- data/presets/presets/barrier/fence.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 082f87b5e..05253e1b0 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -2837,7 +2837,7 @@ "matchScore": 0.25 }, "barrier/fence": { - "icon": "barrier", + "icon": "fence", "fields": [ "fence_type", "height" diff --git a/data/presets/presets/barrier/fence.json b/data/presets/presets/barrier/fence.json index 7576ecb9d..7ba3b3f43 100644 --- a/data/presets/presets/barrier/fence.json +++ b/data/presets/presets/barrier/fence.json @@ -1,5 +1,5 @@ { - "icon": "barrier", + "icon": "fence", "fields": [ "fence_type", "height" From 0d0f6237e751477321d532fce55bc6a5f0354b21 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:33:57 +0530 Subject: [PATCH 22/31] Rename entrance to entrance-alt1 --- data/presets/presets.json | 8 ++++---- data/presets/presets/amenity/parking_entrance.json | 2 +- data/presets/presets/barrier/_entrance.json | 4 ++-- data/presets/presets/building/_entrance.json | 2 +- data/presets/presets/entrance.json | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index 05253e1b0..4a20b8142 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -1552,7 +1552,7 @@ "name": "Nightclub" }, "amenity/parking_entrance": { - "icon": "entrance", + "icon": "entrance-alt1", "fields": [ "access_simple", "ref" @@ -2733,7 +2733,7 @@ "matchScore": 0.4 }, "barrier/entrance": { - "icon": "entrance", + "icon": "entrance-alt1", "geometry": [ "vertex" ], @@ -3008,7 +3008,7 @@ "searchable": false }, "building/entrance": { - "icon": "entrance", + "icon": "entrance-alt1", "geometry": [ "vertex" ], @@ -4601,7 +4601,7 @@ "name": "Emergency Phone" }, "entrance": { - "icon": "entrance", + "icon": "entrance-alt1", "geometry": [ "vertex" ], diff --git a/data/presets/presets/amenity/parking_entrance.json b/data/presets/presets/amenity/parking_entrance.json index ecf2b7f3b..73eb813b5 100644 --- a/data/presets/presets/amenity/parking_entrance.json +++ b/data/presets/presets/amenity/parking_entrance.json @@ -1,5 +1,5 @@ { - "icon": "entrance", + "icon": "entrance-alt1", "fields": [ "access_simple", "ref" diff --git a/data/presets/presets/barrier/_entrance.json b/data/presets/presets/barrier/_entrance.json index 0d063e102..dc98d2446 100644 --- a/data/presets/presets/barrier/_entrance.json +++ b/data/presets/presets/barrier/_entrance.json @@ -1,5 +1,5 @@ { - "icon": "entrance", + "icon": "entrance-alt1", "geometry": [ "vertex" ], @@ -8,4 +8,4 @@ }, "name": "Entrance", "searchable": false -} \ No newline at end of file +} diff --git a/data/presets/presets/building/_entrance.json b/data/presets/presets/building/_entrance.json index 9c66caa2c..c39c7e988 100644 --- a/data/presets/presets/building/_entrance.json +++ b/data/presets/presets/building/_entrance.json @@ -1,5 +1,5 @@ { - "icon": "entrance", + "icon": "entrance-alt1", "geometry": [ "vertex" ], diff --git a/data/presets/presets/entrance.json b/data/presets/presets/entrance.json index a61e8268b..3d6a7ec86 100644 --- a/data/presets/presets/entrance.json +++ b/data/presets/presets/entrance.json @@ -1,5 +1,5 @@ { - "icon": "entrance", + "icon": "entrance-alt1", "geometry": [ "vertex" ], From 9292bfdc288d476721d3d88ac5914e433465f224 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:36:06 +0530 Subject: [PATCH 23/31] Use defibrillator --- data/presets/presets.json | 1 + data/presets/presets/emergency/defibrillator.json | 1 + 2 files changed, 2 insertions(+) diff --git a/data/presets/presets.json b/data/presets/presets.json index 4a20b8142..81ae5fb56 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -4551,6 +4551,7 @@ "name": "Ambulance Station" }, "emergency/defibrillator": { + "icon": "defibrillator", "fields": [ "access", "opening_hours", diff --git a/data/presets/presets/emergency/defibrillator.json b/data/presets/presets/emergency/defibrillator.json index 700a1e087..0fdb2b3be 100644 --- a/data/presets/presets/emergency/defibrillator.json +++ b/data/presets/presets/emergency/defibrillator.json @@ -1,4 +1,5 @@ { + "icon": "defibrillator", "fields": [ "access", "opening_hours", From 4ed4cf67d269714ea8c0af2e250bb8f5069f5243 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:38:39 +0530 Subject: [PATCH 24/31] Use horse-riding --- data/presets/presets.json | 1 + data/presets/presets/leisure/horse_riding.json | 1 + 2 files changed, 2 insertions(+) diff --git a/data/presets/presets.json b/data/presets/presets.json index 81ae5fb56..eb1aea4e9 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -6779,6 +6779,7 @@ "name": "Golf Course" }, "leisure/horse_riding": { + "icon": "horse-riding", "fields": [ "access_simple", "operator", diff --git a/data/presets/presets/leisure/horse_riding.json b/data/presets/presets/leisure/horse_riding.json index d8759f4ac..977b0c912 100644 --- a/data/presets/presets/leisure/horse_riding.json +++ b/data/presets/presets/leisure/horse_riding.json @@ -1,4 +1,5 @@ { + "icon": "horse-riding", "fields": [ "access_simple", "operator", From 04fe8a5b6caaa009f8cb28a1740cf0bdfcd2c374 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 16:47:14 +0530 Subject: [PATCH 25/31] Use drinking-water --- data/presets/presets.json | 4 ++-- data/presets/presets/amenity/drinking_water.json | 2 +- data/presets/presets/amenity/water_point.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index eb1aea4e9..b94d11b42 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -1159,7 +1159,7 @@ "name": "Dojo / Martial Arts Academy" }, "amenity/drinking_water": { - "icon": "water", + "icon": "drinking-water", "geometry": [ "point" ], @@ -2682,7 +2682,7 @@ "name": "Waste Transfer Station" }, "amenity/water_point": { - "icon": "water", + "icon": "drinking-water", "geometry": [ "area", "vertex", diff --git a/data/presets/presets/amenity/drinking_water.json b/data/presets/presets/amenity/drinking_water.json index 9437c6024..cff034bb7 100644 --- a/data/presets/presets/amenity/drinking_water.json +++ b/data/presets/presets/amenity/drinking_water.json @@ -1,5 +1,5 @@ { - "icon": "water", + "icon": "drinking-water", "geometry": [ "point" ], diff --git a/data/presets/presets/amenity/water_point.json b/data/presets/presets/amenity/water_point.json index 0cdce3f52..834a6f99f 100644 --- a/data/presets/presets/amenity/water_point.json +++ b/data/presets/presets/amenity/water_point.json @@ -1,5 +1,5 @@ { - "icon": "water", + "icon": "drinking-water", "geometry": [ "area", "vertex", From 95c3d31c791b00af136ac024fea23e3302e134ee Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 17:46:43 +0530 Subject: [PATCH 26/31] Don't add tag classes to maki icons --- modules/ui/preset_icon.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ui/preset_icon.js b/modules/ui/preset_icon.js index 9fb02427e..86e5c5dca 100644 --- a/modules/ui/preset_icon.js +++ b/modules/ui/preset_icon.js @@ -71,7 +71,7 @@ export function uiPresetIcon() { icon.selectAll('svg') .attr('class', function() { - return 'icon ' + picon + tag_classes(p); + return 'icon ' + picon + (isMaki ? '' : tag_classes(p)); }); icon.selectAll('use') From cb26859192450b623939d1aa7993c9628092eb9c Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 17:48:15 +0530 Subject: [PATCH 27/31] Use entrance icon for subway_entrance, fixes #3255 --- data/presets/presets.json | 2 +- data/presets/presets/railway/subway_entrance.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/data/presets/presets.json b/data/presets/presets.json index b94d11b42..16867e3bd 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -9127,7 +9127,7 @@ "name": "Railway Station" }, "railway/subway_entrance": { - "icon": "rail-metro", + "icon": "entrance", "geometry": [ "point" ], diff --git a/data/presets/presets/railway/subway_entrance.json b/data/presets/presets/railway/subway_entrance.json index cba2d4101..687d7a904 100644 --- a/data/presets/presets/railway/subway_entrance.json +++ b/data/presets/presets/railway/subway_entrance.json @@ -1,5 +1,5 @@ { - "icon": "rail-metro", + "icon": "entrance", "geometry": [ "point" ], @@ -8,4 +8,4 @@ }, "terms": [], "name": "Subway Entrance" -} \ No newline at end of file +} From 69a6f1ccf3be2c65c121a451a226b5881b9762ea Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 18:10:59 +0530 Subject: [PATCH 28/31] Add a natural features category, fixes #2843 --- data/presets.yaml | 6 ++++ data/presets/categories.json | 37 ++++++++++++++++++++++ data/presets/categories/natual-line.json | 9 ++++++ data/presets/categories/natural-area.json | 17 ++++++++++ data/presets/categories/natural-point.json | 11 +++++++ data/presets/presets.json | 1 + data/presets/presets/natural/cliff.json | 1 + dist/locales/en.json | 9 ++++++ 8 files changed, 91 insertions(+) create mode 100644 data/presets/categories/natual-line.json create mode 100644 data/presets/categories/natural-area.json create mode 100644 data/presets/categories/natural-point.json diff --git a/data/presets.yaml b/data/presets.yaml index a0258fc1c..2df24a7a0 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -9,6 +9,12 @@ en: name: Golf Features category-landuse: name: Land Use Features + category-natual-line: + name: Natural Features + category-natural-area: + name: Natural Features + category-natural-point: + name: Natural Features category-path: name: Path Features category-rail: diff --git a/data/presets/categories.json b/data/presets/categories.json index be59ba85e..b777baef5 100644 --- a/data/presets/categories.json +++ b/data/presets/categories.json @@ -56,6 +56,43 @@ "landuse/military" ] }, + "category-natual-line": { + "geometry": "line", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/coastline", + "natural/tree_row" + ] + }, + "category-natural-area": { + "geometry": "area", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/water", + "natural/wood", + "natural/scrub", + "natural/wetland", + "natural/grassland", + "natural/heath", + "natural/bare_rock", + "natural/beach", + "natural/cave_entrance", + "natural/glacier" + ] + }, + "category-natural-point": { + "geometry": "point", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/peak", + "natural/cliff", + "natural/beach", + "natural/cave_entrance" + ] + }, "category-path": { "geometry": "line", "name": "Path Features", diff --git a/data/presets/categories/natual-line.json b/data/presets/categories/natual-line.json new file mode 100644 index 000000000..a69c82959 --- /dev/null +++ b/data/presets/categories/natual-line.json @@ -0,0 +1,9 @@ +{ + "geometry": "line", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/coastline", + "natural/tree_row" + ] +} diff --git a/data/presets/categories/natural-area.json b/data/presets/categories/natural-area.json new file mode 100644 index 000000000..8d18cf536 --- /dev/null +++ b/data/presets/categories/natural-area.json @@ -0,0 +1,17 @@ +{ + "geometry": "area", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/water", + "natural/wood", + "natural/scrub", + "natural/wetland", + "natural/grassland", + "natural/heath", + "natural/bare_rock", + "natural/beach", + "natural/cave_entrance", + "natural/glacier" + ] +} diff --git a/data/presets/categories/natural-point.json b/data/presets/categories/natural-point.json new file mode 100644 index 000000000..3950b59ed --- /dev/null +++ b/data/presets/categories/natural-point.json @@ -0,0 +1,11 @@ +{ + "geometry": "point", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/peak", + "natural/cliff", + "natural/beach", + "natural/cave_entrance" + ] +} diff --git a/data/presets/presets.json b/data/presets/presets.json index 16867e3bd..8d659e91b 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -7827,6 +7827,7 @@ "name": "Cave Entrance" }, "natural/cliff": { + "icon": "triangle", "geometry": [ "point", "vertex", diff --git a/data/presets/presets/natural/cliff.json b/data/presets/presets/natural/cliff.json index ea857bebb..74f49ca8f 100644 --- a/data/presets/presets/natural/cliff.json +++ b/data/presets/presets/natural/cliff.json @@ -1,4 +1,5 @@ { + "icon": "triangle", "geometry": [ "point", "vertex", diff --git a/dist/locales/en.json b/dist/locales/en.json index ed981101a..e4bba2118 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -707,6 +707,15 @@ "category-landuse": { "name": "Land Use Features" }, + "category-natual-line": { + "name": "Natural Features" + }, + "category-natural-area": { + "name": "Natural Features" + }, + "category-natural-point": { + "name": "Natural Features" + }, "category-path": { "name": "Path Features" }, From 50eb129de53656050677b2e8e81baaf3c2cd9557 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 18:16:42 +0530 Subject: [PATCH 29/31] Use information icon for tourist information office --- data/presets/presets.json | 1 + data/presets/presets/tourism/information/office.json | 1 + 2 files changed, 2 insertions(+) diff --git a/data/presets/presets.json b/data/presets/presets.json index 8d659e91b..b34bbd5dc 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -11773,6 +11773,7 @@ "name": "Map" }, "tourism/information/office": { + "icon": "information", "fields": [ "operator", "address", diff --git a/data/presets/presets/tourism/information/office.json b/data/presets/presets/tourism/information/office.json index 945f213ba..4a57d4d1b 100644 --- a/data/presets/presets/tourism/information/office.json +++ b/data/presets/presets/tourism/information/office.json @@ -1,4 +1,5 @@ { + "icon": "information", "fields": [ "operator", "address", From c026be39e5a8b59e39b2e75f9da392d6298220a7 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 18:20:54 +0530 Subject: [PATCH 30/31] Use bbq for barbeque/grill --- data/presets/presets.json | 1 + data/presets/presets/amenity/bbq.json | 1 + 2 files changed, 2 insertions(+) diff --git a/data/presets/presets.json b/data/presets/presets.json index b34bbd5dc..a157cee69 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -637,6 +637,7 @@ "name": "Bar" }, "amenity/bbq": { + "icon": "bbq", "fields": [ "covered", "fuel" diff --git a/data/presets/presets/amenity/bbq.json b/data/presets/presets/amenity/bbq.json index 18d37ad53..5478da5f5 100644 --- a/data/presets/presets/amenity/bbq.json +++ b/data/presets/presets/amenity/bbq.json @@ -1,4 +1,5 @@ { + "icon": "bbq", "fields": [ "covered", "fuel" From 1efa7fe237c9255fc52487e8635959f9fe1e27d2 Mon Sep 17 00:00:00 2001 From: Ajith Ranka Date: Fri, 13 Jan 2017 18:40:42 +0530 Subject: [PATCH 31/31] Show natural features by default --- data/presets.yaml | 4 ++-- data/presets/categories.json | 18 +++++++++--------- .../{natual-line.json => natural-line.json} | 0 data/presets/defaults.json | 3 +++ dist/locales/en.json | 4 ++-- 5 files changed, 16 insertions(+), 13 deletions(-) rename data/presets/categories/{natual-line.json => natural-line.json} (100%) diff --git a/data/presets.yaml b/data/presets.yaml index 2df24a7a0..10fbee7e9 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -9,10 +9,10 @@ en: name: Golf Features category-landuse: name: Land Use Features - category-natual-line: - name: Natural Features category-natural-area: name: Natural Features + category-natural-line: + name: Natural Features category-natural-point: name: Natural Features category-path: diff --git a/data/presets/categories.json b/data/presets/categories.json index b777baef5..3a9f56d41 100644 --- a/data/presets/categories.json +++ b/data/presets/categories.json @@ -56,15 +56,6 @@ "landuse/military" ] }, - "category-natual-line": { - "geometry": "line", - "name": "Natural Features", - "icon": "natural", - "members": [ - "natural/coastline", - "natural/tree_row" - ] - }, "category-natural-area": { "geometry": "area", "name": "Natural Features", @@ -82,6 +73,15 @@ "natural/glacier" ] }, + "category-natural-line": { + "geometry": "line", + "name": "Natural Features", + "icon": "natural", + "members": [ + "natural/coastline", + "natural/tree_row" + ] + }, "category-natural-point": { "geometry": "point", "name": "Natural Features", diff --git a/data/presets/categories/natual-line.json b/data/presets/categories/natural-line.json similarity index 100% rename from data/presets/categories/natual-line.json rename to data/presets/categories/natural-line.json diff --git a/data/presets/defaults.json b/data/presets/defaults.json index b89dd8214..dcaba3e38 100644 --- a/data/presets/defaults.json +++ b/data/presets/defaults.json @@ -4,6 +4,7 @@ "category-landuse", "category-building", "category-water-area", + "category-natural-area", "leisure/park", "amenity/hospital", "amenity/place_of_worship", @@ -17,10 +18,12 @@ "category-path", "category-water-line", "category-barrier", + "category-natural-line", "power/line", "line" ], "point": [ + "category-natural-point", "leisure/park", "amenity/hospital", "amenity/place_of_worship", diff --git a/dist/locales/en.json b/dist/locales/en.json index e4bba2118..4dc8e45f4 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -707,10 +707,10 @@ "category-landuse": { "name": "Land Use Features" }, - "category-natual-line": { + "category-natural-area": { "name": "Natural Features" }, - "category-natural-area": { + "category-natural-line": { "name": "Natural Features" }, "category-natural-point": {