CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-12 16:52:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

validate suspicious names using the user's language (#9522)

Browse Source
This commit is contained in:
Kyℓe Hensel
2025-02-17 21:42:04 +11:00
committed by GitHub
parent f513ccd03d
commit 8f9d7e01bf
3 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/spec/validations/suspicious_name.js
View File

@@ -31,6 +31,10 @@ describe('iD.validations.suspicious_name', function () {
iD.fileFetcher.cache().nsi_generics = {
genericWords: ['^stores?$']
};
iD.fileFetcher.cache().preset_presets = {
'Velero': { tags: { craft: 'sailmaker' }, geometry: ['line'] },
'Constructor de barco': { tags: { craft: 'boatbuilder' }, geometry: ['line'] },
};
});
after(function() {
@@ -183,4 +187,29 @@ describe('iD.validations.suspicious_name', function () {
done();
}, 20);
});
it('flags feature with a name that matches the preset name', async () => {
await iD.presetManager.ensureLoaded(true);
createWay({ craft: 'sailmaker', 'name:ca': 'Velero' });
const validator = iD.validationSuspiciousName(context);
const issues = validate(validator);
expect(issues).to.have.lengthOf(1);
expect(issues[0].type).to.eql('suspicious_name');
expect(issues[0].hash).to.eql('name:ca=Velero');
});
it('flags feature with a name that matches the preset name and tag name', async () => {
await iD.presetManager.ensureLoaded(true);
createWay({ craft: 'boatbuilder', 'name:mi': 'boatbuilder', name: 'cOnStRuCtOr de barco' });
const validator = iD.validationSuspiciousName(context);
const issues = validate(validator);
expect(issues).to.have.lengthOf(2);
expect(issues[0].type).to.eql('suspicious_name');
expect(issues[0].hash).to.eql('name:mi=boatbuilder');
expect(issues[1].type).to.eql('suspicious_name');
expect(issues[1].hash).to.eql('name=cOnStRuCtOr de barco');
});
});