From 94096beb6865109ab9e814d5039cd89154a00161 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Wed, 13 Mar 2019 11:56:09 -0400 Subject: [PATCH] Flag lines with a highway service tag but no highway=service tag --- data/presets.yaml | 10 +++++----- data/presets/presets.json | 10 +++++----- data/presets/presets/highway/service/alley.json | 7 +++++++ .../presets/presets/highway/service/drive-through.json | 7 +++++++ data/presets/presets/highway/service/driveway.json | 7 +++++++ .../presets/highway/service/emergency_access.json | 7 +++++++ .../presets/presets/highway/service/parking_aisle.json | 7 +++++++ 7 files changed, 45 insertions(+), 10 deletions(-) diff --git a/data/presets.yaml b/data/presets.yaml index 18420b11a..765973f83 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -4161,23 +4161,23 @@ en: # 'terms: road,street' terms: '' highway/service/alley: - # 'highway=service, service=alley' + # service=alley name: Alley terms: '' highway/service/drive-through: - # 'highway=service, service=drive-through' + # service=drive-through name: Drive-Through terms: '' highway/service/driveway: - # 'highway=service, service=driveway' + # service=driveway name: Driveway terms: '' highway/service/emergency_access: - # 'highway=service, service=emergency_access' + # service=emergency_access name: Emergency Access terms: '' highway/service/parking_aisle: - # 'highway=service, service=parking_aisle' + # service=parking_aisle name: Parking Aisle terms: '' highway/services: diff --git a/data/presets/presets.json b/data/presets/presets.json index fdcd45932..9a402534a 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -454,11 +454,11 @@ "highway/secondary_link": {"icon": "iD-highway-secondary-link", "fields": ["{highway/primary_link}"], "moreFields": ["{highway/primary_link}"], "geometry": ["line"], "tags": {"highway": "secondary_link"}, "terms": ["on ramp", "off ramp", "ramp", "road", "street"], "name": "Secondary Link"}, "highway/secondary": {"icon": "iD-highway-secondary", "fields": ["{highway/primary}"], "moreFields": ["{highway/primary}"], "geometry": ["line"], "tags": {"highway": "secondary"}, "terms": ["road", "street"], "name": "Secondary Road"}, "highway/service": {"icon": "iD-highway-service", "fields": ["name", "service", "oneway", "maxspeed", "surface", "structure", "access"], "moreFields": ["covered", "lanes", "lit", "maxheight", "maxspeed/advisory", "oneway/bicycle"], "geometry": ["line"], "tags": {"highway": "service"}, "terms": ["road", "street"], "name": "Service Road"}, - "highway/service/alley": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"highway": "service", "service": "alley"}, "reference": {"key": "service", "value": "alley"}, "name": "Alley"}, - "highway/service/drive-through": {"icon": "iD-highway-service", "fields": ["{highway/service}", "covered"], "geometry": ["line"], "tags": {"highway": "service", "service": "drive-through"}, "reference": {"key": "service", "value": "drive-through"}, "name": "Drive-Through"}, - "highway/service/driveway": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"highway": "service", "service": "driveway"}, "reference": {"key": "service", "value": "driveway"}, "name": "Driveway"}, - "highway/service/emergency_access": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"highway": "service", "service": "emergency_access"}, "reference": {"key": "service", "value": "emergency_access"}, "name": "Emergency Access"}, - "highway/service/parking_aisle": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"highway": "service", "service": "parking_aisle"}, "reference": {"key": "service", "value": "parking_aisle"}, "name": "Parking Aisle"}, + "highway/service/alley": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"service": "alley"}, "addTags": {"highway": "service", "service": "alley"}, "removeTags": {"highway": "service", "service": "alley"}, "reference": {"key": "service", "value": "alley"}, "name": "Alley"}, + "highway/service/drive-through": {"icon": "iD-highway-service", "fields": ["{highway/service}", "covered"], "geometry": ["line"], "tags": {"service": "drive-through"}, "addTags": {"highway": "service", "service": "drive-through"}, "removeTags": {"highway": "service", "service": "drive-through"}, "reference": {"key": "service", "value": "drive-through"}, "name": "Drive-Through"}, + "highway/service/driveway": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"service": "driveway"}, "addTags": {"highway": "service", "service": "driveway"}, "removeTags": {"highway": "service", "service": "driveway"}, "reference": {"key": "service", "value": "driveway"}, "name": "Driveway"}, + "highway/service/emergency_access": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"service": "emergency_access"}, "addTags": {"highway": "service", "service": "emergency_access"}, "removeTags": {"highway": "service", "service": "emergency_access"}, "reference": {"key": "service", "value": "emergency_access"}, "name": "Emergency Access"}, + "highway/service/parking_aisle": {"icon": "iD-highway-service", "geometry": ["line"], "tags": {"service": "parking_aisle"}, "addTags": {"highway": "service", "service": "parking_aisle"}, "removeTags": {"highway": "service", "service": "parking_aisle"}, "reference": {"key": "service", "value": "parking_aisle"}, "name": "Parking Aisle"}, "highway/services": {"icon": "maki-car", "fields": ["{highway/rest_area}"], "moreFields": ["{highway/rest_area}"], "geometry": ["point", "vertex", "area"], "tags": {"highway": "services"}, "terms": ["services", "travel plaza", "service station"], "name": "Service Area"}, "highway/speed_camera": {"icon": "maki-attraction", "geometry": ["point", "vertex"], "fields": ["direction", "ref", "maxspeed"], "tags": {"highway": "speed_camera"}, "terms": [], "name": "Speed Camera"}, "highway/steps": {"icon": "iD-highway-steps", "fields": ["incline_steps", "handrail", "step_count", "surface", "lit", "width"], "moreFields": ["covered", "dog"], "geometry": ["line"], "tags": {"highway": "steps"}, "terms": ["stairs", "staircase", "stairway"], "name": "Steps"}, diff --git a/data/presets/presets/highway/service/alley.json b/data/presets/presets/highway/service/alley.json index ce84eeab6..fb8ddc412 100644 --- a/data/presets/presets/highway/service/alley.json +++ b/data/presets/presets/highway/service/alley.json @@ -4,6 +4,13 @@ "line" ], "tags": { + "service": "alley" + }, + "addTags": { + "highway": "service", + "service": "alley" + }, + "removeTags": { "highway": "service", "service": "alley" }, diff --git a/data/presets/presets/highway/service/drive-through.json b/data/presets/presets/highway/service/drive-through.json index 6eada87a0..aa77c59c1 100644 --- a/data/presets/presets/highway/service/drive-through.json +++ b/data/presets/presets/highway/service/drive-through.json @@ -8,6 +8,13 @@ "line" ], "tags": { + "service": "drive-through" + }, + "addTags": { + "highway": "service", + "service": "drive-through" + }, + "removeTags": { "highway": "service", "service": "drive-through" }, diff --git a/data/presets/presets/highway/service/driveway.json b/data/presets/presets/highway/service/driveway.json index 26fc62fcf..801e0d790 100644 --- a/data/presets/presets/highway/service/driveway.json +++ b/data/presets/presets/highway/service/driveway.json @@ -4,6 +4,13 @@ "line" ], "tags": { + "service": "driveway" + }, + "addTags": { + "highway": "service", + "service": "driveway" + }, + "removeTags": { "highway": "service", "service": "driveway" }, diff --git a/data/presets/presets/highway/service/emergency_access.json b/data/presets/presets/highway/service/emergency_access.json index 1eed046c8..ad82395c5 100644 --- a/data/presets/presets/highway/service/emergency_access.json +++ b/data/presets/presets/highway/service/emergency_access.json @@ -4,6 +4,13 @@ "line" ], "tags": { + "service": "emergency_access" + }, + "addTags": { + "highway": "service", + "service": "emergency_access" + }, + "removeTags": { "highway": "service", "service": "emergency_access" }, diff --git a/data/presets/presets/highway/service/parking_aisle.json b/data/presets/presets/highway/service/parking_aisle.json index 2567f06a7..1473fec79 100644 --- a/data/presets/presets/highway/service/parking_aisle.json +++ b/data/presets/presets/highway/service/parking_aisle.json @@ -4,6 +4,13 @@ "line" ], "tags": { + "service": "parking_aisle" + }, + "addTags": { + "highway": "service", + "service": "parking_aisle" + }, + "removeTags": { "highway": "service", "service": "parking_aisle" },