From 977e66745301aa9c5fd617ca29ce989a8ce8d709 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Mon, 4 Feb 2019 11:15:05 -0500 Subject: [PATCH] Remove non-functional issue options from UI --- data/core.yaml | 9 +-------- dist/locales/en.json | 12 +----------- modules/ui/issues.js | 18 ++++++++++++++---- 3 files changed, 16 insertions(+), 23 deletions(-) diff --git a/data/core.yaml b/data/core.yaml index 8dfe83f1b..d355d41e8 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -1174,13 +1174,6 @@ en: icon_tooltip: warning options: title: Options - features_to_validate: - edited: - description: Edited features only - tooltip: Flag issues with features you create and modify - all: - description: All features - tooltip: Flag issues with all nearby features disconnected_way: highway: message: "{highway} is disconnected from other roads and paths." @@ -1243,7 +1236,7 @@ en: undo_redo: Connected crossing features. connect_almost_junction: title: Connect the features - undo_redo: Connected two features that were really close. + undo_redo: Connected two very close features. continue_feature: title: Continue this feature delete_feature: diff --git a/dist/locales/en.json b/dist/locales/en.json index d2017e022..a53ba79b2 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1424,16 +1424,6 @@ "options": { "title": "Options" }, - "features_to_validate": { - "edited": { - "description": "Edited features only", - "tooltip": "Flag issues with features you create and modify" - }, - "all": { - "description": "All features", - "tooltip": "Flag issues with all nearby features" - } - }, "disconnected_way": { "highway": { "message": "{highway} is disconnected from other roads and paths.", @@ -1522,7 +1512,7 @@ }, "connect_almost_junction": { "title": "Connect the features", - "undo_redo": "Connected two features that were really close." + "undo_redo": "Connected two very close features." }, "continue_feature": { "title": "Continue this feature" diff --git a/modules/ui/issues.js b/modules/ui/issues.js index d6019fb1b..b210102d8 100644 --- a/modules/ui/issues.js +++ b/modules/ui/issues.js @@ -242,9 +242,9 @@ export function uiIssues(context) { } } - if (!pane.select('.disclosure-wrap-issues_options').classed('hide')) { - updateFeatureApplicabilityList(); - } + //if (!pane.select('.disclosure-wrap-issues_options').classed('hide')) { + // updateFeatureApplicabilityList(); + //} } function issues(selection) { @@ -340,6 +340,16 @@ export function uiIssues(context) { ); // options + /* + // add this back to core.yaml when re-enabling the options + features_to_validate: + edited: + description: Edited features only + tooltip: Flag issues with features you create and modify + all: + description: All features + tooltip: Flag issues with all nearby features + content .append('div') .attr('class', 'issues-options') @@ -347,7 +357,7 @@ export function uiIssues(context) { .title(t('issues.options.title')) .content(renderIssuesOptions) ); - + */ update(); context.keybinding()