From 9a13c6810bc8b40f34f7e36cbc036be00cd256df Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Tue, 28 Apr 2020 11:10:26 -0700 Subject: [PATCH] Don't flag google drive as an incompatible source (close #7545) --- modules/validations/incompatible_source.js | 2 +- test/spec/validations/incompatible_source.js | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/modules/validations/incompatible_source.js b/modules/validations/incompatible_source.js index 1314dd4bb..772b9e44a 100644 --- a/modules/validations/incompatible_source.js +++ b/modules/validations/incompatible_source.js @@ -7,7 +7,7 @@ export function validationIncompatibleSource() { var type = 'incompatible_source'; var invalidSources = [ { - id:'google', regex:'google', exceptRegex: 'books.google|Google Books' + id:'google', regex:'google', exceptRegex: 'books.google|Google Books|drive.google|googledrive|Google Drive' } ]; diff --git a/test/spec/validations/incompatible_source.js b/test/spec/validations/incompatible_source.js index e80d224fc..1801ac263 100644 --- a/test/spec/validations/incompatible_source.js +++ b/test/spec/validations/incompatible_source.js @@ -47,6 +47,12 @@ describe('iD.validations.incompatible_source', function () { expect(issues).to.have.lengthOf(0); }); + it('ignores way with excepted source tag', function() { + createWay({ amenity: 'cafe', building: 'yes', name: 'Key Largo Café', source: 'Google drive'}); + var issues = validate(); + expect(issues).to.have.lengthOf(0); + }); + it('flags way with incompatible source tag', function() { createWay({ amenity: 'cafe', building: 'yes', name: 'Key Largo Café', source: 'Google Maps'}); var issues = validate();