From a0e8292067f14dcee55042dfb5342a506f0c4ea1 Mon Sep 17 00:00:00 2001 From: Ansis Brammanis Date: Wed, 24 Apr 2013 19:27:43 -0400 Subject: [PATCH] fix tree bug where removes would fail the width or height of the rtree rectangle created by extentRectangle would be negative. These rectangles insert ok, and are found by search, but they cannot be removed. issue #1370 --- js/id/core/tree.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/id/core/tree.js b/js/id/core/tree.js index eff748d37..dcf0fbd1e 100644 --- a/js/id/core/tree.js +++ b/js/id/core/tree.js @@ -10,9 +10,9 @@ iD.Tree = function(graph) { function extentRectangle(extent) { x = m * extent[0][0], y = m * extent[0][1], - dx = m * extent[1][0] - x || 2, - dy = m * extent[1][1] - y || 2; - return new RTree.Rectangle(~~x, ~~y, ~~dx - 1, ~~dy - 1); + dx = Math.max(m * extent[1][0] - x, 1), + dy = Math.max(m * extent[1][1] - y, 1); + return new RTree.Rectangle(~~x, ~~y, ~~dx, ~~dy); } function insert(entity) {