From a85ac34a35cef949cd5c3eaa9174af73f5afdff6 Mon Sep 17 00:00:00 2001 From: Quincy Morgan <2046746+quincylvania@users.noreply.github.com> Date: Thu, 3 Dec 2020 13:50:56 -0500 Subject: [PATCH] Add tooltip to the review request checkbox (close #7227) --- data/core.yaml | 1 + dist/locales/en.json | 1 + modules/ui/commit.js | 5 +++++ 3 files changed, 7 insertions(+) diff --git a/data/core.yaml b/data/core.yaml index c97715be5..33595c94e 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -580,6 +580,7 @@ en: upload_explanation: "The changes you upload will be visible on all maps that use OpenStreetMap data." upload_explanation_with_user: "The changes you upload as {user} will be visible on all maps that use OpenStreetMap data." request_review: "I would like someone to review my edits." + request_review_info: "Unsure about something? Invite an experienced mapper to check your work once it's live." save: Upload cancel: Cancel changes: Changes diff --git a/dist/locales/en.json b/dist/locales/en.json index 8e1e19044..8896251bb 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -769,6 +769,7 @@ "upload_explanation": "The changes you upload will be visible on all maps that use OpenStreetMap data.", "upload_explanation_with_user": "The changes you upload as {user} will be visible on all maps that use OpenStreetMap data.", "request_review": "I would like someone to review my edits.", + "request_review_info": "Unsure about something? Invite an experienced mapper to check your work once it's live.", "save": "Upload", "cancel": "Cancel", "changes": "Changes", diff --git a/modules/ui/commit.js b/modules/ui/commit.js index e3ad030cb..5beec1448 100644 --- a/modules/ui/commit.js +++ b/modules/ui/commit.js @@ -323,6 +323,11 @@ export function uiCommit(context) { .append('label') .attr('for', requestReviewDomId); + if (!labelEnter.empty()) { + labelEnter + .call(uiTooltip().title(t.html('commit.request_review_info')).placement('top')); + } + labelEnter .append('input') .attr('type', 'checkbox')