From af8fb1d758d9ce4a878d5d03c0ab3d27e6f29861 Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Mon, 28 Jan 2019 16:20:34 -0500 Subject: [PATCH] Show combobox if we are moving from a different active combobox (closes #5752) Previously it would go down the `hide()` branch anytime an existing combobox was active. --- modules/ui/combobox.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ui/combobox.js b/modules/ui/combobox.js index e8fc6484b..0d66e27e4 100644 --- a/modules/ui/combobox.js +++ b/modules/ui/combobox.js @@ -96,8 +96,9 @@ export function uiCombobox(context, klass) { var end = input.property('selectionEnd'); if (start !== end) return; // exit if user is selecting + // not showing or showing for a different field - try to show it. var combo = container.selectAll('.combobox'); - if (combo.empty()) { // not showing - try to show it. + if (combo.empty() || combo.datum() !== input) { var tOrig = _tDown; window.setTimeout(function() { if (tOrig !== _tDown) return; // exit if user double clicked