From b05be80e5321743974daf35d96d96f9eef8cad72 Mon Sep 17 00:00:00 2001
From: Martin Raifer <martin@raifer.tech>
Date: Wed, 23 Apr 2025 12:35:15 +0200
Subject: [PATCH] only show outdated tags warning if there are tags to upgrade,
 fixes #10980

---
 modules/validations/outdated_tags.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/validations/outdated_tags.js b/modules/validations/outdated_tags.js
index 918fcc26f..35c020ec5 100644
--- a/modules/validations/outdated_tags.js
+++ b/modules/validations/outdated_tags.js
@@ -91,8 +91,8 @@ export function validationOutdatedTags() {
         }
       });
     }
-    const deprecationDiff = utilTagDiff(oldTags, newTags).concat(
-      Object.keys(oldTags)
+    const deprecationDiff = utilTagDiff(oldTags, newTags);
+    const deprecationDiffContext = Object.keys(oldTags)
         .filter(key => deprecatedTags?.some(deprecated => deprecated.replace?.[key] !== undefined))
         .filter(key => newTags[key] === oldTags[key])
         .map(key => ({
@@ -101,7 +101,7 @@ export function validationOutdatedTags() {
           oldVal: oldTags[key],
           newVal: newTags[key],
           display: '&nbsp; ' + key + '=' + oldTags[key]
-        })));
+        }));
 
     let issues = [];
     issues.provisional = (_waitingForDeprecated || waitingForNsi);
@@ -125,7 +125,7 @@ export function validationOutdatedTags() {
         reference: selection => showReference(
           selection,
           t.append(`issues.outdated_tags.${prefix}reference`),
-          deprecationDiff
+          [...deprecationDiff, ...deprecationDiffContext]
         ),
         entityIds: [entity.id],
         hash: utilHashcode(JSON.stringify(deprecationDiff)),