CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-25 17:37:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add Osmose issue detail fetching for UI

Browse Source 
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
This commit is contained in:
SilentSpike
2019-12-28 21:45:45 +00:00
parent ebd206595a
commit b24b041335
5 changed files with 89 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/services/osmose.js
+33 -8
View File
@@ -92,7 +92,8 @@ export default {
loadErrors: function(projection) {
var params = {
level: '1,2,3'
level: '1,2,3',
item: services.osmose.items.join() // only interested in certain errors
};
// determine the needed tiles to cover the view
@@ -140,11 +141,6 @@ export default {
item: props.item // category of the issue for styling
});
// Variables used in the description
// d.replacements = elems.map(function(i) {
// return linkEntity(i);
// });
_erCache.data[d.id] = d;
_erCache.rtree.insert(encodeErrorRtree(d));
}
@@ -160,7 +156,36 @@ export default {
});
},
// todo: need to fetch specific error details upon UI loading for element IDs
loadErrorDetail: function(d, callback) {
// Error details only need to be fetched once
if (d.elems !== undefined) {
if (callback) callback(null, d);
return;
}
var url = _osmoseUrlRoot + 'en/api/0.3beta/issue/' + d.identifier;
var that = this;
d3_json(url)
.then(function(data) {
// Associated elements used for highlighting
// Assign directly for immediate use in the callback
d.elems = data.elems.map(function(e) {
return e.type.substring(0,1) + e.id;
});
// Element links used in the error description
d.replacements = d.elems.map(function(i) {
return linkEntity(i);
});
that.replaceError(d);
if (callback) callback(null, d);
})
.catch(function(err) {
if (callback) callback(err.message);
});
},
postUpdate: function(d, callback) {
if (_erCache.inflightPost[d.id]) {
@@ -170,7 +195,7 @@ export default {
var that = this;
// UI sets the status to either '/done' or '/false'
var url = _osmoseUrlRoot + 'issue/' + d.identifier + d.newStatus;
var url = _osmoseUrlRoot + 'en/api/0.3beta/issue/' + d.identifier + d.newStatus;
var controller = new AbortController();
_erCache.inflightPost[d.id] = controller;