From b2c8f72c950da13fcbd8161fb6e49192917cc9df Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Sat, 29 Oct 2016 14:42:04 -0400 Subject: [PATCH] no-native-reassign -> no-global-assign --- .eslintrc | 2 +- test/spec/services/mapillary.js | 4 ++-- test/spec/ui/cmd.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.eslintrc b/.eslintrc index d4be26c7a..0e0fbd051 100644 --- a/.eslintrc +++ b/.eslintrc @@ -27,6 +27,7 @@ "no-extend-native": "error", "no-extra-bind": "error", "no-floating-decimal": "error", + "no-global-assign": "error", "no-implied-eval": "error", "no-invalid-this": "off", "no-iterator": "error", @@ -35,7 +36,6 @@ "no-lone-blocks": "error", "no-loop-func": "error", "no-multi-str": "error", - "no-native-reassign": "error", "no-new": "error", "no-new-func": "error", "no-new-wrappers": "error", diff --git a/test/spec/services/mapillary.js b/test/spec/services/mapillary.js index 0b06c05d8..5bf447eeb 100644 --- a/test/spec/services/mapillary.js +++ b/test/spec/services/mapillary.js @@ -15,7 +15,7 @@ describe('iD.serviceMapillary', function() { mapillary = iD.services.mapillary; mapillary.reset(); - /* eslint-disable no-native-reassign */ + /* eslint-disable no-global-assign */ /* mock userAgent */ if (isPhantom) { orig = navigator; @@ -35,7 +35,7 @@ describe('iD.serviceMapillary', function() { } else { navigator.__defineGetter__('userAgent', orig); } - /* eslint-enable no-native-reassign */ + /* eslint-enable no-global-assign */ }); diff --git a/test/spec/ui/cmd.js b/test/spec/ui/cmd.js index 0ff9f70b6..325e77486 100644 --- a/test/spec/ui/cmd.js +++ b/test/spec/ui/cmd.js @@ -5,7 +5,7 @@ describe('iD.uiCmd', function () { uaMock = function () { return ua; }; beforeEach(function() { - /* eslint-disable no-native-reassign */ + /* eslint-disable no-global-assign */ /* mock userAgent */ if (isPhantom) { orig = navigator; @@ -23,7 +23,7 @@ describe('iD.uiCmd', function () { } else { navigator.__defineGetter__('userAgent', orig); } - /* eslint-enable no-native-reassign */ + /* eslint-enable no-global-assign */ }); it('does not overwrite mac keybindings', function () {