From b302d853ac31b41d71dc66bb4563dc6efb559917 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Wed, 27 Feb 2019 13:13:15 -0500
Subject: [PATCH] Fix issue where the favorite preset button could be stale Use
 first in, first out favoriting order

---
 modules/core/context.js     | 9 +++++----
 modules/ui/entity_editor.js | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/modules/core/context.js b/modules/core/context.js
index 2a4425b05..2efa2c4f1 100644
--- a/modules/core/context.js
+++ b/modules/core/context.js
@@ -325,12 +325,13 @@ export function coreContext() {
                 return !(d.id === preset.id && d.geom === geom);
             });
         } else {
-            //only allow 3 favorites
-            //replace the last one
+            // only allow 3 favorites
             if (favs.length === 3) {
-                favs = favs.slice(0,2);
+                // remove the last favorite (first in, first out)
+                favs.pop();
             }
-            favs.push({id: preset.id, geom: geom});
+            // prepend array
+            favs.unshift({id: preset.id, geom: geom});
         }
 
         context.storage('favorite_presets', JSON.stringify(favs));
diff --git a/modules/ui/entity_editor.js b/modules/ui/entity_editor.js
index 7f567424c..eba317e19 100644
--- a/modules/ui/entity_editor.js
+++ b/modules/ui/entity_editor.js
@@ -340,8 +340,8 @@ export function uiEntityEditor(context) {
             _activePreset = val;
             _tagReference = uiTagReference(_activePreset.reference(context.geometry(_entityID)), context)
                 .showing(false);
-            _presetFavorite = uiPresetFavorite(_activePreset, context.geometry(_entityID), context);
         }
+        _presetFavorite = uiPresetFavorite(_activePreset, context.geometry(_entityID), context);
         return entityEditor;
     };