From b7cfaf08da7db5507944d012c4d8a4998b1d90bb Mon Sep 17 00:00:00 2001 From: Tom MacWright Date: Mon, 4 Feb 2013 16:48:44 -0500 Subject: [PATCH] userDetails should handle errors properly --- js/id/connection.js | 1 + js/id/ui/userpanel.js | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/js/id/connection.js b/js/id/connection.js index 794232682..5f5f17482 100644 --- a/js/id/connection.js +++ b/js/id/connection.js @@ -208,6 +208,7 @@ iD.Connection = function(context) { function userDetails(callback) { function done(err, user_details) { + if (err) return callback(err); var u = user_details.getElementsByTagName('user')[0], img = u.getElementsByTagName('img'), image_url = ''; diff --git a/js/id/ui/userpanel.js b/js/id/ui/userpanel.js index 2b28411a6..fda2fc463 100644 --- a/js/id/ui/userpanel.js +++ b/js/id/ui/userpanel.js @@ -5,10 +5,12 @@ iD.ui.userpanel = function(connection) { function update() { if (connection.authenticated()) { selection.style('display', 'block'); - connection.userDetails(function(user_details) { + connection.userDetails(function(err, user_details) { selection.html(''); + if (err) return; + // Link var userLink = selection.append('a') .attr('href', connection.url() + '/user/' +