From b93e9f1a1a6b4fa32f60650031940be6a0cc8436 Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Wed, 26 Oct 2016 11:31:19 -0400 Subject: [PATCH] Merge enter selection into update selection for raw member list (closes #3524) --- modules/ui/raw_member_editor.js | 8 +++++--- modules/ui/raw_membership_editor.js | 1 - 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/modules/ui/raw_member_editor.js b/modules/ui/raw_member_editor.js index be47cca2e..6c24c2e34 100644 --- a/modules/ui/raw_member_editor.js +++ b/modules/ui/raw_member_editor.js @@ -77,9 +77,11 @@ export function uiRawMemberEditor(context) { var list = wrap.selectAll('.member-list') .data([0]); - list.enter() + list = list.enter() .append('ul') - .attr('class', 'member-list'); + .attr('class', 'member-list') + .merge(list); + var items = list.selectAll('li') .data(memberships, function(d) { @@ -116,7 +118,7 @@ export function uiRawMemberEditor(context) { } else { d3.select(this).append('label') .attr('class', 'form-label') - .text(t('inspector.incomplete')); + .text(t('inspector.incomplete', { id: d.id })); } }); diff --git a/modules/ui/raw_membership_editor.js b/modules/ui/raw_membership_editor.js index c46b8b864..9118ba77d 100644 --- a/modules/ui/raw_membership_editor.js +++ b/modules/ui/raw_membership_editor.js @@ -23,7 +23,6 @@ export function uiRawMembershipEditor(context) { id, showBlank; - function selectRelation(d) { d3.event.preventDefault(); context.enter(modeSelect(context, [d.relation.id]));