From ba97dde0f2d48fe000794dc7e8d0b7834157bf2a Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Wed, 26 Apr 2017 01:15:16 -0400 Subject: [PATCH] Limit members editor and memberships editor to 1000 entrires (closes #3737) --- modules/ui/raw_member_editor.js | 5 +++-- modules/ui/raw_membership_editor.js | 6 ++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/modules/ui/raw_member_editor.js b/modules/ui/raw_member_editor.js index 8ff9be43b..234930a69 100644 --- a/modules/ui/raw_member_editor.js +++ b/modules/ui/raw_member_editor.js @@ -51,7 +51,7 @@ export function uiRawMemberEditor(context) { var entity = context.entity(id), memberships = []; - entity.members.forEach(function(member, index) { + entity.members.slice(0, 1000).forEach(function(member, index) { memberships.push({ index: index, id: member.id, @@ -62,8 +62,9 @@ export function uiRawMemberEditor(context) { }); }); + var gt = entity.members.length > 1000 ? '>' : ''; selection.call(uiDisclosure() - .title(t('inspector.all_members') + ' (' + memberships.length + ')') + .title(t('inspector.all_members') + ' (' + gt + memberships.length + ')') .expanded(true) .on('toggled', toggled) .content(content) diff --git a/modules/ui/raw_membership_editor.js b/modules/ui/raw_membership_editor.js index 76973dd70..47ca15638 100644 --- a/modules/ui/raw_membership_editor.js +++ b/modules/ui/raw_membership_editor.js @@ -117,9 +117,10 @@ export function uiRawMembershipEditor(context) { function rawMembershipEditor(selection) { var entity = context.entity(id), + parents = context.graph().parentRelations(entity), memberships = []; - context.graph().parentRelations(entity).forEach(function(relation) { + parents.slice(0, 1000).forEach(function(relation) { relation.members.forEach(function(member, index) { if (member.id === entity.id) { memberships.push({ relation: relation, member: member, index: index }); @@ -127,8 +128,9 @@ export function uiRawMembershipEditor(context) { }); }); + var gt = parents.length > 1000 ? '>' : ''; selection.call(uiDisclosure() - .title(t('inspector.all_relations') + ' (' + memberships.length + ')') + .title(t('inspector.all_relations') + ' (' + gt + memberships.length + ')') .expanded(true) .on('toggled', toggled) .content(content)