CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-21 07:46:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

loadEntity can use entityCache, but loadEntityVersion should not

Browse Source
This commit is contained in:
Bryan Housel
2017-08-24 15:02:12 -04:00
parent cabc98649f
commit cd05c51432
3 changed files with 52 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/spec/services/osm.js
+35
View File
@@ -320,6 +320,23 @@ describe('iD.serviceOsm', function () {
[200, { 'Content-Type': 'text/xml' }, wayXML]);
server.respond();
});
it('ignores repeat requests using entityCache', function(done) {
var id = 'n1';
connection.loadEntity(id, function(err, result) {
var entity = _.find(result.data, function(e) { return e.id === id; });
expect(entity).to.be.an.instanceOf(iD.Node);
connection.loadEntity(id, function(err, result) {
expect(result.data).to.eql([]);
done();
});
server.respond();
});
server.respondWith('GET', 'http://www.openstreetmap.org/api/0.6/node/1',
[200, { 'Content-Type': 'text/xml' }, nodeXML]);
server.respond();
});
});
describe('#loadEntityVersion', function () {
@@ -363,6 +380,24 @@ describe('iD.serviceOsm', function () {
[200, { 'Content-Type': 'text/xml' }, wayXML]);
server.respond();
});
it('does not ignore repeat requests', function(done) {
var id = 'n1';
connection.loadEntityVersion(id, 1, function(err1, result1) {
var entity1 = _.find(result1.data, function(e1) { return e1.id === id; });
expect(entity1).to.be.an.instanceOf(iD.Node);
connection.loadEntityVersion(id, 1, function(err2, result2) {
var entity2 = _.find(result2.data, function(e2) { return e2.id === id; });
expect(entity2).to.be.an.instanceOf(iD.Node);
done();
});
server.respond();
});
server.respondWith('GET', 'http://www.openstreetmap.org/api/0.6/node/1/1',
[200, { 'Content-Type': 'text/xml' }, nodeXML]);
server.respond();
});
});
describe('#loadMultiple', function () {