diff --git a/css/30_highways.css b/css/30_highways.css index 931533625..d1f2e90c4 100644 --- a/css/30_highways.css +++ b/css/30_highways.css @@ -458,7 +458,7 @@ path.line.casing.tag-service { } /* special service roads and bus guideways */ -/* with `service=* tag` (e.g. parking_aisle, alley, drive-through */ +/* with `service=* tag` (e.g. parking_aisle, alley, drive-through) */ .preset-icon .icon.iD-highway-bus_guideway, .preset-icon .icon.iD-highway-service.tag-service { color: #dca; diff --git a/css/50_misc.css b/css/50_misc.css index 265d641bb..fe454adab 100644 --- a/css/50_misc.css +++ b/css/50_misc.css @@ -3,6 +3,7 @@ path.line.shadow.tag-aerialway, path.line.shadow.tag-attraction-summer_toboggan, path.line.shadow.tag-attraction-water_slide, +path.line.shadow.tag-golf-cartpath, path.line.shadow.tag-man_made-pipeline, path.line.shadow.tag-natural-tree_row, path.line.shadow.tag-piste { @@ -11,6 +12,7 @@ path.line.shadow.tag-piste { path.line.casing.tag-aerialway, path.line.casing.tag-attraction-summer_toboggan, path.line.casing.tag-attraction-water_slide, +path.line.casing.tag-golf-cartpath, path.line.casing.tag-man_made-pipeline, path.line.casing.tag-natural-tree_row, path.line.casing.tag-piste { @@ -19,6 +21,7 @@ path.line.casing.tag-piste { path.line.stroke.tag-aerialway, path.line.stroke.tag-attraction-summer_toboggan, path.line.stroke.tag-attraction-water_slide, +path.line.stroke.tag-golf-cartpath, path.line.stroke.tag-man_made-pipeline, path.line.stroke.tag-natural-tree_row, path.line.stroke.tag-piste { @@ -28,6 +31,7 @@ path.line.stroke.tag-piste { .low-zoom path.line.shadow.tag-aerialway, .low-zoom path.line.shadow.tag-attraction-summer_toboggan, .low-zoom path.line.shadow.tag-attraction-water_slide, +.low-zoom path.line.shadow.tag-golf-cartpath, .low-zoom path.line.shadow.tag-man_made-pipeline, .low-zoom path.line.shadow.tag-natural-tree_row, .low-zoom path.line.shadow.tag-piste { @@ -36,6 +40,7 @@ path.line.stroke.tag-piste { .low-zoom path.line.casing.tag-aerialway, .low-zoom path.line.casing.tag-attraction-summer_toboggan, .low-zoom path.line.casing.tag-attraction-water_slide, +.low-zoom path.line.casing.tag-golf-cartpath, .low-zoom path.line.casing.tag-man_made-pipeline, .low-zoom path.line.casing.tag-natural-tree_row, .low-zoom path.line.casing.tag-piste { @@ -44,6 +49,7 @@ path.line.stroke.tag-piste { .low-zoom path.line.stroke.tag-aerialway, .low-zoom path.line.stroke.tag-attraction-summer_toboggan, .low-zoom path.line.stroke.tag-attraction-water_slide, +.low-zoom path.line.stroke.tag-golf-cartpath, .low-zoom path.line.stroke.tag-man_made-pipeline, .low-zoom path.line.stroke.tag-natural-tree_row, .low-zoom path.line.stroke.tag-piste { @@ -84,6 +90,7 @@ path.line.casing.tag-aerialway { stroke: #444; } + /* pistes */ path.line.stroke.tag-piste { stroke: #9ac; @@ -92,6 +99,36 @@ path.line.casing.tag-piste { stroke: #444; } + +/* Attractions */ +path.line.stroke.tag-attraction-summer_toboggan { + stroke: #9e9e9e; +} +path.line.casing.tag-attraction-summer_toboggan { + stroke: #666; +} + +path.line.stroke.tag-attraction-water_slide { + stroke: #aae0cb; +} +path.line.casing.tag-attraction-water_slide { + stroke: #3d6c71; +} + + +/* golf cartpaths (like service roads) */ +.preset-icon .icon.tag-golf-cartpath { + color: #dca; + fill: #666; +} +path.line.stroke.tag-golf-cartpath { + stroke: #dca; +} +path.line.casing.tag-golf-cartpath { + stroke: #666; +} + + /* power and pipeline */ .preset-icon .icon.tag-man_made-pipeline, .preset-icon .icon.tag-power { @@ -362,6 +399,7 @@ path.fill.tag-building { /* "Special" paths - platforms, piers, crossings */ +.preset-icon .icon.tag-golf-path, .preset-icon .icon.tag-public_transport-platform, .preset-icon .icon.tag-railway-platform, .preset-icon .icon.tag-man_made-pier, @@ -371,6 +409,7 @@ path.fill.tag-building { fill: #dca; } +.preset-icon-fill-area.tag-golf-path, .preset-icon-fill-area.tag-public_transport-platform, .preset-icon-fill-area.tag-railway-platform, .preset-icon-fill-area.tag-man_made-pier, @@ -380,6 +419,7 @@ path.fill.tag-building { background-color: #dca; } +path.line.shadow.tag-golf-path, path.line.shadow.tag-public_transport-platform, path.line.shadow.tag-railway-platform, path.line.shadow.tag-man_made-pier, @@ -387,6 +427,7 @@ path.line.shadow.tag-footway.tag-footway-crossing, path.line.shadow.tag-crossing { stroke-width: 16; } +path.line.casing.tag-golf-path, path.line.casing.tag-public_transport-platform, path.line.casing.tag-railway-platform, path.line.casing.tag-man_made-pier, @@ -397,6 +438,7 @@ path.line.casing.tag-crossing { stroke-linecap: round; stroke-dasharray: none; } +path.line.stroke.tag-golf-path, path.line.stroke.tag-public_transport-platform, path.line.stroke.tag-railway-platform, path.line.stroke.tag-man_made-pier, @@ -408,6 +450,7 @@ path.line.stroke.tag-crossing { stroke-dasharray: 6, 6; } +.low-zoom path.line.shadow.tag-golf-path, .low-zoom path.line.shadow.tag-public_transport-platform, .low-zoom path.line.shadow.tag-railway-platform, .low-zoom path.line.shadow.tag-man_made-pier, @@ -415,6 +458,7 @@ path.line.stroke.tag-crossing { .low-zoom path.line.shadow.tag-crossing { stroke-width: 12; } +.low-zoom path.line.casing.tag-golf-path, .low-zoom path.line.casing.tag-public_transport-platform, .low-zoom path.line.casing.tag-railway-platform, .low-zoom path.line.casing.tag-man_made-pier, @@ -422,6 +466,7 @@ path.line.stroke.tag-crossing { .low-zoom path.line.casing.tag-crossing { stroke-width: 3; } +.low-zoom path.line.stroke.tag-golf-path, .low-zoom path.line.stroke.tag-public_transport-platform, .low-zoom path.line.stroke.tag-railway-platform, .low-zoom path.line.stroke.tag-man_made-pier, @@ -432,6 +477,7 @@ path.line.stroke.tag-crossing { stroke-dasharray: 3, 3; } +g.midpoint.tag-golf-path .fill, g.midpoint.tag-public_transport-platform .fill, g.midpoint.tag-railway-platform .fill, g.midpoint.tag-man_made-pier .fill, @@ -462,18 +508,3 @@ path.line.stroke.tag-crossing.tag-crossing-zebra { .low-zoom path.line.stroke.tag-crossing.tag-crossing-zebra { stroke-dasharray: 3, 2; } - -/* Attractions */ -path.line.stroke.tag-attraction-summer_toboggan { - stroke: #9e9e9e; -} -path.line.casing.tag-attraction-summer_toboggan { - stroke: #666; -} - -path.line.stroke.tag-attraction-water_slide { - stroke: #aae0cb; -} -path.line.casing.tag-attraction-water_slide { - stroke: #3d6c71; -} diff --git a/data/presets.yaml b/data/presets.yaml index 312d2fa88..032041999 100644 --- a/data/presets.yaml +++ b/data/presets.yaml @@ -5,7 +5,9 @@ en: name: Barrier Features category-building: name: Building Features - category-golf: + category-golf-area: + name: Golf Features + category-golf-line: name: Golf Features category-landuse: name: Land Use Features @@ -3780,6 +3782,18 @@ en: name: Sand Trap # 'terms: hazard,bunker' terms: '' + golf/cartpath: + # 'golf=cartpath, golf_cart=designated' + name: Golf Cartpath + terms: '' + golf/cartpath_service: + # 'highway=service, golf=cartpath, golf_cart=designated' + name: Golf Cartpath / Service Road + terms: '' + golf/driving_range: + # 'golf=driving_range, landuse=grass' + name: Driving Range + terms: '' golf/fairway: # 'golf=fairway, landuse=grass' name: Fairway @@ -3800,6 +3814,10 @@ en: # golf=lateral_water_hazard name: Lateral Water Hazard terms: '' + golf/path: + # 'golf=path, foot=designated' + name: Golf Walking Path + terms: '' golf/rough: # 'golf=rough, landuse=grass' name: Rough diff --git a/data/presets/categories.json b/data/presets/categories.json index cfead76e5..6f8a7230a 100644 --- a/data/presets/categories.json +++ b/data/presets/categories.json @@ -51,7 +51,7 @@ "members": [ "golf/hole", "golf/cartpath", - "golf/cartpath_multipurpose", + "golf/cartpath_service", "golf/path" ] }, diff --git a/data/presets/categories/golf-line.json b/data/presets/categories/golf-line.json index dc7623c84..f108f968d 100644 --- a/data/presets/categories/golf-line.json +++ b/data/presets/categories/golf-line.json @@ -5,7 +5,7 @@ "members": [ "golf/hole", "golf/cartpath", - "golf/cartpath_multipurpose", + "golf/cartpath_service", "golf/path" ] } diff --git a/data/presets/presets.json b/data/presets/presets.json index 7b5f723e2..3c03ab32a 100644 --- a/data/presets/presets.json +++ b/data/presets/presets.json @@ -375,11 +375,15 @@ "entrance": {"icon": "maki-entrance-alt1", "geometry": ["vertex"], "terms": ["entrance", "exit", "door"], "tags": {"entrance": "*"}, "fields": ["entrance", "access_simple", "address"], "name": "Entrance/Exit"}, "ford": {"geometry": ["vertex"], "tags": {"ford": "yes"}, "name": "Ford"}, "golf/bunker": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "bunker", "natural": "sand"}, "terms": ["hazard", "bunker"], "reference": {"key": "golf", "value": "bunker"}, "name": "Sand Trap"}, + "golf/cartpath_service": {"icon": "maki-golf", "fields": ["{golf/path}", "maxspeed"], "geometry": ["line"], "tags": {"highway": "service", "golf": "cartpath", "golf_cart": "designated"}, "reference": {"key": "golf", "value": "cartpath"}, "name": "Golf Cartpath / Service Road"}, + "golf/cartpath": {"icon": "maki-golf", "fields": ["{golf/path}"], "geometry": ["line"], "tags": {"golf": "cartpath", "golf_cart": "designated"}, "reference": {"key": "golf", "value": "cartpath"}, "name": "Golf Cartpath"}, + "golf/driving_range": {"icon": "maki-golf", "fields": ["name", "capacity"], "geometry": ["area"], "tags": {"golf": "driving_range", "landuse": "grass"}, "reference": {"key": "golf", "value": "driving_range"}, "name": "Driving Range"}, "golf/fairway": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "fairway", "landuse": "grass"}, "reference": {"key": "golf", "value": "fairway"}, "name": "Fairway"}, "golf/green": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "green", "landuse": "grass", "leisure": "pitch", "sport": "golf"}, "reference": {"key": "golf", "value": "green"}, "name": "Putting Green"}, "golf/hole": {"icon": "maki-golf", "fields": ["name", "ref_golf_hole", "par", "handicap"], "geometry": ["line"], "tags": {"golf": "hole"}, "name": "Golf Hole"}, "golf/lateral_water_hazard_area": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "lateral_water_hazard", "natural": "water"}, "reference": {"key": "golf", "value": "lateral_water_hazard"}, "name": "Lateral Water Hazard"}, "golf/lateral_water_hazard_line": {"icon": "maki-golf", "fields": ["name"], "geometry": ["line"], "tags": {"golf": "lateral_water_hazard"}, "name": "Lateral Water Hazard"}, + "golf/path": {"icon": "maki-golf", "fields": ["name", "surface", "width", "structure", "incline"], "geometry": ["line"], "tags": {"golf": "path", "foot": "designated"}, "reference": {"key": "golf", "value": "path"}, "name": "Golf Walking Path"}, "golf/rough": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "rough", "landuse": "grass"}, "reference": {"key": "golf", "value": "rough"}, "name": "Rough"}, "golf/tee": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "tee", "landuse": "grass"}, "terms": ["teeing ground"], "reference": {"key": "golf", "value": "tee"}, "name": "Tee Box"}, "golf/water_hazard_area": {"icon": "maki-golf", "fields": ["name"], "geometry": ["area"], "tags": {"golf": "water_hazard", "natural": "water"}, "reference": {"key": "golf", "value": "water_hazard"}, "name": "Water Hazard"}, diff --git a/data/presets/presets/golf/cartpath.json b/data/presets/presets/golf/cartpath.json index 323a8ec24..45e5892c9 100644 --- a/data/presets/presets/golf/cartpath.json +++ b/data/presets/presets/golf/cartpath.json @@ -1,12 +1,7 @@ { "icon": "maki-golf", "fields": [ - "name", - "surface", - "width", - "structure", - "access", - "incline" + "{golf/path}" ], "geometry": [ "line" diff --git a/data/presets/presets/golf/cartpath_multipurpose.json b/data/presets/presets/golf/cartpath_service.json similarity index 65% rename from data/presets/presets/golf/cartpath_multipurpose.json rename to data/presets/presets/golf/cartpath_service.json index cabc31cb5..ff3d463b1 100644 --- a/data/presets/presets/golf/cartpath_multipurpose.json +++ b/data/presets/presets/golf/cartpath_service.json @@ -1,12 +1,8 @@ { "icon": "maki-golf", "fields": [ - "name", - "surface", - "width", - "structure", - "access", - "incline" + "{golf/path}", + "maxspeed" ], "geometry": [ "line" @@ -20,5 +16,5 @@ "key": "golf", "value": "cartpath" }, - "name": "Golf Cartpath Multipurpose" + "name": "Golf Cartpath / Service Road" } diff --git a/data/presets/presets/golf/driving_range.json b/data/presets/presets/golf/driving_range.json index 6a7cb955b..4db26eada 100644 --- a/data/presets/presets/golf/driving_range.json +++ b/data/presets/presets/golf/driving_range.json @@ -1,7 +1,8 @@ { "icon": "maki-golf", "fields": [ - "name" + "name", + "capacity" ], "geometry": [ "area" diff --git a/data/presets/presets/golf/path.json b/data/presets/presets/golf/path.json index 7c6b5c9a3..8f4941788 100644 --- a/data/presets/presets/golf/path.json +++ b/data/presets/presets/golf/path.json @@ -5,7 +5,6 @@ "surface", "width", "structure", - "access", "incline" ], "geometry": [ diff --git a/data/taginfo.json b/data/taginfo.json index ad4cbd770..c85088808 100644 --- a/data/taginfo.json +++ b/data/taginfo.json @@ -375,13 +375,13 @@ {"key": "entrance", "description": "🄿 Entrance/Exit, 🄵 Type", "object_types": ["node"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/entrance-alt1-15.svg?sanitize=true"}, {"key": "ford", "value": "yes", "description": "🄿 Ford", "object_types": ["node"]}, {"key": "natural", "value": "sand", "description": "🄿 Sand Trap, 🄿 Sand", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, - {"key": "landuse", "value": "grass", "description": "🄿 Fairway, 🄿 Rough, 🄿 Tee Box, 🄿 Driving Range, 🄿 Grass", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, + {"key": "golf_cart", "value": "designated", "description": "🄿 Golf Cartpath / Service Road, 🄿 Golf Cartpath", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, + {"key": "landuse", "value": "grass", "description": "🄿 Driving Range, 🄿 Fairway, 🄿 Rough, 🄿 Tee Box, 🄿 Grass", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, {"key": "sport", "value": "golf", "description": "🄿 Putting Green", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, {"key": "golf", "value": "hole", "description": "🄿 Golf Hole", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, - {"key": "golf", "value": "cartpath", "description": "🄿 Golf CartPath", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, - {"key": "golf", "value": "path", "description": "🄿 Golf Walking Path", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, {"key": "natural", "value": "water", "description": "🄿 Lateral Water Hazard, 🄿 Water Hazard, 🄿 Water", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, {"key": "golf", "value": "lateral_water_hazard", "description": "🄿 Lateral Water Hazard", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, + {"key": "foot", "value": "designated", "description": "🄿 Golf Walking Path, 🄵 Allowed Access", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, {"key": "golf", "value": "water_hazard", "description": "🄿 Water Hazard", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"}, {"key": "healthcare", "description": "🄿 Healthcare Facility, 🄵 Type", "object_types": ["node", "area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/hospital-15.svg?sanitize=true"}, {"key": "healthcare", "value": "alternative", "description": "🄿 Alternative Medicine", "object_types": ["node", "area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/hospital-15.svg?sanitize=true"}, @@ -1037,7 +1037,6 @@ {"key": "foot", "value": "no", "description": "🄵 Allowed Access"}, {"key": "foot", "value": "permissive", "description": "🄵 Allowed Access"}, {"key": "foot", "value": "private", "description": "🄵 Allowed Access"}, - {"key": "foot", "value": "designated", "description": "🄵 Allowed Access"}, {"key": "foot", "value": "destination", "description": "🄵 Allowed Access"}, {"key": "foot", "value": "dismount", "description": "🄵 Allowed Access"}, {"key": "foot", "value": "permit", "description": "🄵 Allowed Access"}, diff --git a/dist/locales/en.json b/dist/locales/en.json index 1f3f0488c..de0f1d772 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1833,7 +1833,10 @@ "category-building": { "name": "Building Features" }, - "category-golf": { + "category-golf-area": { + "name": "Golf Features" + }, + "category-golf-line": { "name": "Golf Features" }, "category-landuse": { @@ -5146,6 +5149,18 @@ "name": "Sand Trap", "terms": "hazard,bunker" }, + "golf/cartpath_service": { + "name": "Golf Cartpath / Service Road", + "terms": "" + }, + "golf/cartpath": { + "name": "Golf Cartpath", + "terms": "" + }, + "golf/driving_range": { + "name": "Driving Range", + "terms": "" + }, "golf/fairway": { "name": "Fairway", "terms": "" @@ -5166,6 +5181,10 @@ "name": "Lateral Water Hazard", "terms": "" }, + "golf/path": { + "name": "Golf Walking Path", + "terms": "" + }, "golf/rough": { "name": "Rough", "terms": "" diff --git a/modules/svg/tag_classes.js b/modules/svg/tag_classes.js index 0e0a08479..9d3b4a158 100644 --- a/modules/svg/tag_classes.js +++ b/modules/svg/tag_classes.js @@ -15,7 +15,7 @@ export function svgTagClasses() { var secondaries = [ 'oneway', 'bridge', 'tunnel', 'embankment', 'cutting', 'barrier', 'surface', 'tracktype', 'footway', 'crossing', 'service', 'sport', - 'public_transport', 'location', 'parking' + 'public_transport', 'location', 'parking', 'golf' ]; var _tags = function(entity) { return entity.tags; };