From d39f61fffb42cf22cf3dd3c2016ef1151cf79c93 Mon Sep 17 00:00:00 2001 From: Martin Raifer Date: Fri, 31 Jan 2025 12:24:22 +0100 Subject: [PATCH] update contribution regarding new translatable strings (Reverts commit ffc369df3d03d4759898f9dd2b6225ce42047491: "don't gitignore en.min.json file") --- .gitignore | 3 +-- CONTRIBUTING.md | 9 ++++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.gitignore b/.gitignore index e7954c278..f7c993b4e 100644 --- a/.gitignore +++ b/.gitignore @@ -13,8 +13,7 @@ transifex.auth /dist/*.map /dist/data/ /dist/img/*.svg -/dist/locales/*.json -!/dist/locales/en.min.json +/dist/locales/en.min.json /dist/mapillary-js/ /dist/pannellum/ diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ed48d3ed1..0b5a4c7a2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -277,11 +277,10 @@ only display them in the interface through the `t()` function. Then, add the new string to `data/core.yaml`. The translation system, Transifex, will automatically detect the change. -If you are updating an existing string, update it in `data/core.yaml` and run -`npm run build` to generate the `en.json` file automatically, then commit both -modified files. - -Use `npm run build` to build the translations with the local changes. +If you are adding or updating an existing string, update it in `data/core.yaml` +and run `npm run build` to generate the `en.min.json` file automatically. Only +commit the `data/core.yaml` file in your pull request. The translation system, +Transifex, will automatically detect the changes. `npm run translations` can be used to pull the latest translations from Transifex.