From da1fe8343a90b3db7b0a83ae7ba8023b948c6a84 Mon Sep 17 00:00:00 2001
From: Bryan Housel <bryan@mapbox.com>
Date: Fri, 12 Apr 2019 12:49:47 -0400
Subject: [PATCH] Remove mode checking code from missing_tag, as these validate
 anytime

This was causing it to not immediately flag "area with no tags" as an error.
(until the user edited the area some other way)
---
 modules/validations/incompatible_source.js | 4 +---
 modules/validations/maprules.js            | 3 ---
 modules/validations/missing_tag.js         | 8 --------
 3 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/modules/validations/incompatible_source.js b/modules/validations/incompatible_source.js
index c72f5f046..e26ded2aa 100644
--- a/modules/validations/incompatible_source.js
+++ b/modules/validations/incompatible_source.js
@@ -5,14 +5,12 @@ import { validationIssue, validationIssueFix } from '../core/validator';
 
 export function validationIncompatibleSource() {
     var type = 'incompatible_source';
-
     var invalidSources = [{id:'google', regex:'google'}];
 
-    var validation = function(entity, context) {
+    var validation = function checkIncompatibleSource(entity, context) {
         var issues = [];
 
         if (entity.tags && entity.tags.source) {
-            
             invalidSources.forEach(function(invalidSource) {
                 var pattern = new RegExp(invalidSource.regex, 'i');
 
diff --git a/modules/validations/maprules.js b/modules/validations/maprules.js
index e2a876713..5a66b8ec9 100644
--- a/modules/validations/maprules.js
+++ b/modules/validations/maprules.js
@@ -4,12 +4,10 @@ import { services } from '../services';
 export function validationMaprules() {
     var type = 'maprules';
 
-
     var validation = function checkMaprules(entity, context) {
         if (!services.maprules) return [];
 
         var graph = context.graph();
-
         var rules = services.maprules.validationRules();
         var issues = [];
 
@@ -24,6 +22,5 @@ export function validationMaprules() {
 
     validation.type = type;
 
-
     return validation;
 }
diff --git a/modules/validations/missing_tag.js b/modules/validations/missing_tag.js
index b487b157f..9842aef5b 100644
--- a/modules/validations/missing_tag.js
+++ b/modules/validations/missing_tag.js
@@ -34,14 +34,6 @@ export function validationMissingTag() {
             return [];
         }
 
-        var mode = context.mode();
-        if (entity.type === 'way' && mode &&
-            (mode.id === 'draw-area' || (mode.id === 'draw-line' && !mode.isContinuing)) &&
-            mode.wayID === entity.id) {
-            // don't flag missing tag issues if drawing a new way
-            return [];
-        }
-
         var messageObj = {};
         var missingTagType;