From dfd46a9e06c4a2ad400b9a8102d80f8eccce9465 Mon Sep 17 00:00:00 2001 From: Martin Raifer Date: Thu, 19 Jan 2023 12:03:36 +0100 Subject: [PATCH] update tests, add to changelog --- CHANGELOG.md | 2 ++ test/spec/validations/crossing_ways.js | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a05b4f76..6b03e22aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -41,6 +41,7 @@ _Breaking developer changes, which may affect downstream projects or sites that * Show a _remaining input length_ indicator and a warning if the maximum for OSM tags (typically, 255 characters) is exceeded ([#9390], [#9392] thanks [@alanb43], [#7943], [#9374]) #### :sparkles: Usability & Accessibility #### :white_check_mark: Validation +* Add support value `uncontrolled` when using _connect features_ validation fix on crossings with `crossing=uncontrolled` ([#9443], thanks [@arch0345]) #### :bug: Bugfixes * Fix bug which made it impossible to change an object's preset from a sub-preset to the respective parents preset (e.g. from Driveway to Service Road) ([#9372]) * Fix corruption of (directional) `cycleway` tags when editing a multi-selection ([#9423]) @@ -71,6 +72,7 @@ _Breaking developer changes, which may affect downstream projects or sites that [#9413]: https://github.com/openstreetmap/iD/pull/9413 [#9423]: https://github.com/openstreetmap/iD/pull/9423 [#9434]: https://github.com/openstreetmap/iD/pull/9434 +[#9443]: https://github.com/openstreetmap/iD/pull/9443 [#9446]: https://github.com/openstreetmap/iD/pull/9446 [#9471]: https://github.com/openstreetmap/iD/issues/9471 [#9458]: https://github.com/openstreetmap/iD/pull/9458 diff --git a/test/spec/validations/crossing_ways.js b/test/spec/validations/crossing_ways.js index 308af2272..57ce0ff95 100644 --- a/test/spec/validations/crossing_ways.js +++ b/test/spec/validations/crossing_ways.js @@ -214,6 +214,11 @@ describe('iD.validations.crossing_ways', function () { }); it('flags road crossing marked crosswalk', function() { + createWaysWithOneCrossingPoint({ highway: 'residential' }, { highway: 'footway', crossing: 'uncontrolled' }); + verifySingleCrossingIssue(validate(), { highway: 'crossing', crossing: 'uncontrolled' }); + }); + + it('flags road crossing marked crosswalk (alternative tagging)', function() { createWaysWithOneCrossingPoint({ highway: 'residential' }, { highway: 'footway', crossing: 'marked' }); verifySingleCrossingIssue(validate(), { highway: 'crossing', crossing: 'marked' }); });