diff --git a/CHANGELOG.md b/CHANGELOG.md index 06ffe2c05..50c03a80f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -67,6 +67,7 @@ _Breaking developer changes, which may affect downstream projects or sites that * Fix a bug where the validator might show wrong tagging suggestions for a preset if another preset has a partial match ([#8828], thanks [@bhousel]) * Show correct vintage and other metadata for "Esri World Imagery"'s higher zoom levels * Fix wrong order of route relation members after a split operation ([#8519], thanks [@tpetillon]) +* Do not open disabled localized combobox when clicking on it ([#8871], thanks [@hodigabi]) #### :earth_asia: Localization * Deprecate ~`t.html`~ for providing localized texts, which is replaced by the new method `t.append` which directly and safely appends the localized strings to the DOM ([#8817]) #### :hourglass: Performance @@ -105,6 +106,7 @@ _Breaking developer changes, which may affect downstream projects or sites that [#8836]: https://github.com/openstreetmap/iD/issues/8836 [#8839]: https://github.com/openstreetmap/iD/pull/8839 [#8860]: https://github.com/openstreetmap/iD/pull/8860 +[#8871]: https://github.com/openstreetmap/iD/issues/8871 [#8876]: https://github.com/openstreetmap/iD/pull/8876 [#8906]: https://github.com/openstreetmap/iD/pull/8906 [@k-yle]: https://github.com/k-yle diff --git a/modules/ui/combobox.js b/modules/ui/combobox.js index 57555078f..df3d13700 100644 --- a/modules/ui/combobox.js +++ b/modules/ui/combobox.js @@ -77,6 +77,7 @@ export function uiCombobox(context, klass) { function mousedown(d3_event) { if (d3_event.button !== 0) return; // left click only + if (input.classed('disabled')) return; _tDown = +new Date(); // clear selection @@ -95,6 +96,7 @@ export function uiCombobox(context, klass) { function mouseup(d3_event) { input.on('mouseup.combo-input', null); if (d3_event.button !== 0) return; // left click only + if (input.classed('disabled')) return; if (input.node() !== document.activeElement) return; // exit if this input is not focused var start = input.property('selectionStart'); diff --git a/modules/ui/fields/localized.js b/modules/ui/fields/localized.js index ac02435ab..547eed76b 100644 --- a/modules/ui/fields/localized.js +++ b/modules/ui/fields/localized.js @@ -213,7 +213,7 @@ export function uiFieldLocalized(field, context) { localizedInputs.selectAll('button, input') .classed('disabled', !!isLocked) .attr('readonly', isLocked || null); - + selection.selectAll('.combobox-caret').classed('nope', true); function addNew(d3_event) {