From ef48fb0c505509b6419655d9ada08e302c317866 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Tue, 14 Apr 2020 15:52:05 -0700 Subject: [PATCH] Fix potential error in crossing ways validation --- modules/validations/crossing_ways.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/validations/crossing_ways.js b/modules/validations/crossing_ways.js index cf6559219..bd8863f4b 100644 --- a/modules/validations/crossing_ways.js +++ b/modules/validations/crossing_ways.js @@ -307,8 +307,9 @@ export function validationCrossingWays(context) { (!member.role || member.role === 'outer' || member.role === 'inner')) { var entity = graph.hasEntity(member.id); // don't add duplicates - if (!entity || array.indexOf(entity) !== -1) return; - array.push(entity); + if (entity && array.indexOf(entity) === -1) { + array.push(entity); + } } return array; }, []);