From c11ac6ed896a0ab2046413c08190da66bb4db0ef Mon Sep 17 00:00:00 2001
From: Andrew Wong <wongavision@gmail.com>
Date: Wed, 19 Dec 2018 12:53:25 -0500
Subject: [PATCH 1/3] added missing_tag test

---
 test/index.html                      |  1 +
 test/spec/validations/missing_tag.js | 43 ++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 test/spec/validations/missing_tag.js

diff --git a/test/index.html b/test/index.html
index b455624b3..30f39cf6c 100644
--- a/test/index.html
+++ b/test/index.html
@@ -143,6 +143,7 @@
     <script src='spec/util/session_mutex.js'></script>
     <script src='spec/util/util.js'></script>
 
+    <script src='spec/validations/missing_tag.js'></script>
     <script src='spec/operations/detach_node.js'></script>
     <script>
         window.mocha.run();
diff --git a/test/spec/validations/missing_tag.js b/test/spec/validations/missing_tag.js
new file mode 100644
index 000000000..1aba5b59c
--- /dev/null
+++ b/test/spec/validations/missing_tag.js
@@ -0,0 +1,43 @@
+describe('iD.validations.missing_tag', function () {
+    var context;
+
+    beforeEach(function() {
+        context = iD.Context();
+    });
+
+    function createInvalidWay() {
+        var n1 = iD.Node({id: 'n-1', loc: [4,4]});
+        var n2 = iD.Node({id: 'n-2', loc: [4,5]});
+
+        var w = iD.Way({id: 'w-1', nodes: ['n-1', 'n-2']});
+
+        context.perform(
+            iD.actionAddEntity(n1),
+            iD.actionAddEntity(n2),
+            iD.actionAddEntity(w)
+        );
+    }
+
+    function validate() {
+        var validator = iD.validationMissingTag();
+        var changes = context.history().changes();
+        return validator(changes, context.graph());
+    }
+
+    it('has no errors on init', function() {
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('finds missing tags', function() {
+        createInvalidWay();
+        var issues = validate();
+        expect(issues).to.have.lengthOf(1);
+        var issue = issues[0];
+        expect(issue.type).to.eql(iD.ValidationIssueType.missing_tag);
+        expect(issue.entities).to.have.lengthOf(1);
+        expect(issue.entities[0].id).to.eql('w-1');
+    });
+
+
+});

From 6ae25eada7637d9f7d2c6ffce5adbe674c7db247 Mon Sep 17 00:00:00 2001
From: Andrew Wong <wongavision@gmail.com>
Date: Wed, 19 Dec 2018 13:07:41 -0500
Subject: [PATCH 2/3] fixing tests around issues

---
 modules/services/maprules.js   |  6 ++++++
 test/spec/services/maprules.js | 11 +++++------
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/modules/services/maprules.js b/modules/services/maprules.js
index f3b34450d..567ce2967 100644
--- a/modules/services/maprules.js
+++ b/modules/services/maprules.js
@@ -3,6 +3,12 @@ import _intersection from 'lodash-es/intersection';
 import _reduce from 'lodash-es/reduce';
 import _every from 'lodash-es/every';
 
+import {
+    ValidationIssueType,
+    ValidationIssueSeverity,
+    validationIssue
+} from '../validations/validation_issue';
+
 var buildRuleChecks = function() {
     return {
         equals: function (equals) {
diff --git a/test/spec/services/maprules.js b/test/spec/services/maprules.js
index 188588d0e..bfa2a1df5 100644
--- a/test/spec/services/maprules.js
+++ b/test/spec/services/maprules.js
@@ -546,18 +546,18 @@ describe('maprules', function() {
                 selectors.forEach(function(selector) { iD.serviceMapRules.addRule(selector); });
                 validationRules = iD.serviceMapRules.validationRules();
             });
-            it('finds warnings', function() {
+            it('finds issues', function() {
                 validationRules.forEach(function(rule, i) {
-                    var warnings = [];
+                    var issues = [];
                     var entity = entities[i];
                     var selector = selectors[i];
 
-                    rule.findWarnings(entity, _graph, warnings);
+                    rule.findIssues(entity, _graph, issues);
 
-                    var warning = warnings[0];
+                    var warning = issues[0];
                     var type = Object.keys(selector).indexOf('error') ? 'error' : 'warning';
 
-                    expect(warnings.length).to.eql(1);
+                    expect(issues.length).to.eql(1);
                     expect(warning.entity).to.eql(entity);
                     expect(warning.message).to.eql(selector[type]);
                     expect(type).to.eql(warning.severity);
@@ -566,4 +566,3 @@ describe('maprules', function() {
         });
     });
 });
-

From 0e34313d1d987a928a68a3c16b33b114c5822105 Mon Sep 17 00:00:00 2001
From: Andrew Wong <wongavision@gmail.com>
Date: Wed, 19 Dec 2018 13:32:48 -0500
Subject: [PATCH 3/3] fixed maprules test

---
 test/spec/services/maprules.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/spec/services/maprules.js b/test/spec/services/maprules.js
index bfa2a1df5..7249d6392 100644
--- a/test/spec/services/maprules.js
+++ b/test/spec/services/maprules.js
@@ -462,7 +462,7 @@ describe('maprules', function() {
                 expect(rule.matches(entity)).to.be.false;
             });
         });
-        describe('#findWarnings', function() {
+        describe('#findIssues', function() {
             var selectors, entities, _graph;
 
             before(function() {
@@ -554,13 +554,13 @@ describe('maprules', function() {
 
                     rule.findIssues(entity, _graph, issues);
 
-                    var warning = issues[0];
+                    var issue = issues[0];
                     var type = Object.keys(selector).indexOf('error') ? 'error' : 'warning';
 
                     expect(issues.length).to.eql(1);
-                    expect(warning.entity).to.eql(entity);
-                    expect(warning.message).to.eql(selector[type]);
-                    expect(type).to.eql(warning.severity);
+                    expect(issue.entities).to.eql([entity]);
+                    expect(issue.message).to.eql(selector[type]);
+                    expect(type).to.eql(issue.severity);
                 });
             });
         });