From f28d41b44ed0736bef898685827a6d8d31794eb8 Mon Sep 17 00:00:00 2001 From: Quincy Morgan <2046746+quincylvania@users.noreply.github.com> Date: Tue, 15 Sep 2020 11:34:56 -0400 Subject: [PATCH] Localize the format of numbers in translated strings (close #7993) --- modules/core/localizer.js | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/modules/core/localizer.js b/modules/core/localizer.js index 4213595e4..ae59779ba 100644 --- a/modules/core/localizer.js +++ b/modules/core/localizer.js @@ -258,10 +258,19 @@ export function coreLocalizer() { } } if (typeof result === 'string') { - for (let k in replacements) { - const token = `{${k}}`; + for (let key in replacements) { + let value = replacements[key]; + if (typeof value === 'number' && value.toLocaleString) { + // format numbers for the locale + value = value.toLocaleString(locale, { + style: 'decimal', + useGrouping: true, + minimumFractionDigits: 0 + }); + } + const token = `{${key}}`; const regex = new RegExp(token, 'g'); - result = result.replace(regex, replacements[k]); + result = result.replace(regex, value); } } }