From 09cab72cf26734f44275bc313606af245e067c81 Mon Sep 17 00:00:00 2001 From: Til Schneider Date: Tue, 11 Aug 2020 11:47:04 +0200 Subject: [PATCH 1/3] Fix export of `geoVecLengthSquare` --- modules/geo/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/geo/index.js b/modules/geo/index.js index 609e9c8a9..fc716f735 100644 --- a/modules/geo/index.js +++ b/modules/geo/index.js @@ -37,7 +37,7 @@ export { geoVecEqual } from './vector.js'; export { geoVecFloor } from './vector.js'; export { geoVecInterp } from './vector.js'; export { geoVecLength } from './vector.js'; -export { geoVecLengthSquare } from '/vector.js'; +export { geoVecLengthSquare } from './vector.js'; export { geoVecNormalize } from './vector.js'; export { geoVecNormalizedDot } from './vector.js'; export { geoVecProject } from './vector.js'; From cf1c5085d1b1dd0515a00c2ba45124dc1a9e06ee Mon Sep 17 00:00:00 2001 From: Til Schneider Date: Tue, 11 Aug 2020 16:09:51 +0200 Subject: [PATCH 2/3] Fix geometries detection in preset_fields.js `renderDisclosureContent` in `preset_fields.js` tries to detect the geometry types of the selected entities, but the result is always `[]`. Reason: The handler of `_entityIDs.reduce` always returns `true`. So the result of the `reduce` call is `true` as well. `Object.keys(true)` results in `[]`. Fix: The handler of `_entityIDs.reduce` should return the map which collects the geometry types, so `geometries` will be be something like `["line", "vertex"]`. --- modules/ui/sections/preset_fields.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ui/sections/preset_fields.js b/modules/ui/sections/preset_fields.js index 5e8fb2910..a8061e22f 100644 --- a/modules/ui/sections/preset_fields.js +++ b/modules/ui/sections/preset_fields.js @@ -34,7 +34,8 @@ export function uiSectionPresetFields(context) { var graph = context.graph(); var geometries = Object.keys(_entityIDs.reduce(function(geoms, entityID) { - return geoms[graph.entity(entityID).geometry(graph)] = true; + geoms[graph.entity(entityID).geometry(graph)] = true; + return geoms; }, {})); var presetsManager = presetManager; From 00989362d07cf7e756b50e829775cd6ecc8785cd Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Wed, 12 Aug 2020 17:19:10 +0100 Subject: [PATCH 3/3] Fix another changelog typo --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 950f72f41..3367d88bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -464,7 +464,7 @@ You can now: * :warning: Add dedicated initialization step to `coreContext` ([#7304]) * :warning: Remove various convenience functions of `coreContext` * :warning: Fetch JSON resources asynchronously at runtime using `coreFileFetcher` instead of bundling them ([#4994]) -* :warning: Add `coreUploader` to manage programatic uploading of edits ([#7247], [#7333]) +* :warning: Add `coreUploader` to manage programmatic uploading of edits ([#7247], [#7333]) * :warning: Wrap localization functionality into global `localizer` singleton of `coreLocalizer` * :warning: Replace `context.storage()` with global `prefs` singleton of `corePreferences` * Add optimized `coreTree.waySegments` endpoint to return edges overlapping an area