From f7d881ad6004ddc702af06177794a79713cc1c69 Mon Sep 17 00:00:00 2001 From: Tom MacWright Date: Fri, 2 Nov 2012 16:00:11 -0400 Subject: [PATCH] Reorganize, update notes --- NOTES.md | 12 +++++ css/app.css | 13 +++--- index.html | 75 +++++++++++++++++--------------- js/iD/Connection.js | 16 ------- js/iD/Graph.js | 75 -------------------------------- js/iD/UI.js | 13 ++++++ js/iD/actions/CreatePOI.js | 3 ++ js/iD/actions/CreatePOIAction.js | 49 --------------------- js/iD/actions/actions.js | 1 + js/iD/{ => format}/GeoJSON.js | 0 js/iD/{ => format}/XML.js | 0 js/iD/{ => graph}/Entity.js | 0 js/iD/graph/Graph.js | 49 +++++++++++++++++++++ js/iD/{ => graph}/Node.js | 0 js/iD/{ => graph}/Relation.js | 0 js/iD/{ => graph}/Way.js | 0 js/iD/renderer/Map.js | 8 ++-- 17 files changed, 130 insertions(+), 184 deletions(-) delete mode 100644 js/iD/Graph.js create mode 100644 js/iD/UI.js create mode 100644 js/iD/actions/CreatePOI.js delete mode 100644 js/iD/actions/CreatePOIAction.js create mode 100644 js/iD/actions/actions.js rename js/iD/{ => format}/GeoJSON.js (100%) rename js/iD/{ => format}/XML.js (100%) rename js/iD/{ => graph}/Entity.js (100%) create mode 100644 js/iD/graph/Graph.js rename js/iD/{ => graph}/Node.js (100%) rename js/iD/{ => graph}/Relation.js (100%) rename js/iD/{ => graph}/Way.js (100%) diff --git a/NOTES.md b/NOTES.md index 402e8c27f..29d49ba7f 100644 --- a/NOTES.md +++ b/NOTES.md @@ -46,6 +46,18 @@ version, it is like: } ``` +Issues: + +* [Performance seems to suffer with Object.freeze](http://stackoverflow.com/questions/8435080/any-performance-benefit-to-locking-down-javascript-objects). + +The alternative to this approach is changing the object graph itself and keeping +the change data in another representation, like an undo stack. + +At the very least, changes need to have: + +* A name ('Changed 2 Nodes') +* Changes (whether in discrete versions or a 'change object' that can be applied and unapplied) + ## Performance Main performance concerns of iD: diff --git a/css/app.css b/css/app.css index 790d58f21..e025ec9f7 100644 --- a/css/app.css +++ b/css/app.css @@ -107,8 +107,8 @@ table td { width:100px; cursor:pointer; display:inline-block; - background:#fff; - color:#555; + background:#ddd; + color:#222; font:bold 19px/30px 'Helvetica Neue', sans-serif; border:0; border-right:1px solid #222; @@ -118,6 +118,11 @@ table td { margin:0; } +#modebuttons button:hover { + background:#eee; + color:#000; +} + #modebuttons button.mini, #modebuttons button.mini { width:50px; @@ -131,10 +136,6 @@ table td { margin:0; } -#modebuttons button:hover { - background:#eee; -} - #zoombuttons button { cursor:pointer; width:30px; diff --git a/index.html b/index.html index 45df677ed..8c83ace52 100755 --- a/index.html +++ b/index.html @@ -1,27 +1,27 @@ - + iD - - - - + + + + -
+
-
+
-
- +
+
@@ -29,32 +29,36 @@

Work in progress: introduction, code, docs. - Imagery © 2012 Bing, GeoEye, Getmapping, Intermap, Microsoft.

+ Imagery © 2012 Bing, GeoEye, Getmapping, Intermap, Microsoft.

- - - - + + + + - - - + + + - - - - - + + + + + - - - - - - - - + + + + + + + + + + + +