From f8e4e43fab6dc5679f3ae7ee84b4dcc9eb67632f Mon Sep 17 00:00:00 2001
From: Quincy Morgan <2046746+quincylvania@users.noreply.github.com>
Date: Fri, 23 Oct 2020 11:11:32 -0400
Subject: [PATCH] Enable additional eslint rules, including
 no-constructor-return

---
 .eslintrc              | 8 ++++++++
 modules/osm/qa_item.js | 2 --
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index cea6f465d..2bf462e10 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -15,8 +15,11 @@
         "sourceType": "module"
     },
     "rules": {
+        "default-case-last": "error",
+        "default-param-last": "error",
         "dot-notation": "error",
         "eqeqeq": ["error", "smart"],
+        "grouped-accessor-pairs": "error",
         "indent": ["off", 4],
         "keyword-spacing": "error",
         "linebreak-style": ["error", "unix"],
@@ -24,9 +27,12 @@
         "no-caller": "error",
         "no-catch-shadow": "error",
         "no-console": "warn",
+        "no-constructor-return": "error",
         "no-div-regex": "error",
+        "no-eval": "error",
         "no-extend-native": "error",
         "no-extra-bind": "error",
+        "no-extra-label": "error",
         "no-floating-decimal": "error",
         "no-global-assign": "error",
         "no-implied-eval": "error",
@@ -47,7 +53,9 @@
         "no-promise-executor-return": "error",
         "no-proto": "error",
         "no-prototype-builtins": "off",
+        "no-restricted-properties": "error",
         "no-return-assign": "off",
+        "no-return-await": "error",
         "no-script-url": "error",
         "no-self-compare": "error",
         "no-sequences": "error",
diff --git a/modules/osm/qa_item.js b/modules/osm/qa_item.js
index 323a65480..8885f281f 100644
--- a/modules/osm/qa_item.js
+++ b/modules/osm/qa_item.js
@@ -15,8 +15,6 @@ export class QAItem {
     if (service && typeof service.getIcon === 'function') {
       this.icon = service.getIcon(itemType);
     }
-
-    return this;
   }
 
   update(props) {