Generalize deprecated_tags validation to outdated_tags validation

Add check for missing addTags go outdated_tags validation (close #6043, close #6042)
This commit is contained in:
Quincy Morgan
2019-03-12 17:08:20 -04:00
parent 33daa2a969
commit fb25a44017
7 changed files with 89 additions and 131 deletions
+1 -1
View File
@@ -148,11 +148,11 @@
<script src='spec/validations/validator.js'></script>
<script src='spec/validations/almost_junction.js'></script>
<script src='spec/validations/crossing_ways.js'></script>
<script src='spec/validations/deprecated_tag.js'></script>
<script src='spec/validations/disconnected_way.js'></script>
<script src='spec/validations/missing_role.js'></script>
<script src='spec/validations/missing_tag.js'></script>
<script src='spec/validations/old_multipolygon.js'></script>
<script src='spec/validations/outdated_tags.js'></script>
<script src='spec/validations/tag_suggests_area.js'></script>
<script src='spec/operations/detach_node.js'></script>
@@ -1,4 +1,4 @@
describe('iD.validations.deprecated_tag', function () {
describe('iD.validations.outdated_tags', function () {
var context;
beforeEach(function() {
@@ -18,7 +18,7 @@ describe('iD.validations.deprecated_tag', function () {
}
function validate() {
var validator = iD.validationDeprecatedTag();
var validator = iD.validationOutdatedTags();
var changes = context.history().changes();
var entities = changes.modified.concat(changes.created);
var issues = [];
@@ -44,7 +44,7 @@ describe('iD.validations.deprecated_tag', function () {
var issues = validate();
expect(issues).to.have.lengthOf(1);
var issue = issues[0];
expect(issue.type).to.eql('deprecated_tag');
expect(issue.type).to.eql('outdated_tags');
expect(issue.severity).to.eql('warning');
expect(issue.entities).to.have.lengthOf(1);
expect(issue.entities[0].id).to.eql('w-1');